From 64baa5536cc506699c39416d1c5c802b9e5b4ebf Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 16:32:37 -0700 Subject: [PATCH 01/10] update ci --- .github/workflows/ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b683bc1..ec5465b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,13 +13,14 @@ jobs: runs-on: macOS-latest strategy: matrix: - node-version: [12.13.0, 14.x, 16.x] + node-version: [12.13.0, 14.x, 16.x, 18.x, 20.x] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@692973e # v4.1.7 + - uses: actions/setup-node@60edb5d # v4.0.2 with: node-version: ${{ matrix.node-version }} + architecture: 'x64' cache: yarn - name: Install run: yarn --frozen-lockfile @@ -28,7 +29,7 @@ jobs: - name: Test run: yarn coverage - name: Upload code coverage to Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@ab904c4 #v3.1.6 with: file: ./coverage/lcov.info env_vars: NODE_VERSION From fa52446b799cd1205995f438298bf9405bb039ae Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 16:42:04 -0700 Subject: [PATCH 02/10] full sha --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ec5465b..df29bd6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,8 +16,8 @@ jobs: node-version: [12.13.0, 14.x, 16.x, 18.x, 20.x] steps: - - uses: actions/checkout@692973e # v4.1.7 - - uses: actions/setup-node@60edb5d # v4.0.2 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: ${{ matrix.node-version }} architecture: 'x64' @@ -29,7 +29,7 @@ jobs: - name: Test run: yarn coverage - name: Upload code coverage to Codecov - uses: codecov/codecov-action@ab904c4 #v3.1.6 + uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457 #v3.1.6 with: file: ./coverage/lcov.info env_vars: NODE_VERSION From eca09979177d242292bedacbfe7decab0932b739 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 16:54:45 -0700 Subject: [PATCH 03/10] bump nan --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index ae01ed9..160794e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2003,9 +2003,9 @@ murmur-32@^0.1.0: imul "^1.0.0" nan@^2.4.0: - version "2.14.0" - resolved "https://registry.yarnpkg.com/nan/-/nan-2.14.0.tgz#7818f722027b2459a86f0295d434d1fc2336c52c" - integrity sha512-INOFj37C7k3AfaNTtX8RhsTw7qRy7eLET14cROi9+5HAVbbHuIWUHEauBv5qT4Av2tWasiTY1Jw6puUNqRJXQg== + version "2.20.0" + resolved "https://registry.yarnpkg.com/nan/-/nan-2.20.0.tgz#08c5ea813dd54ed16e5bd6505bf42af4f7838ca3" + integrity sha512-bk3gXBZDGILuuo/6sKtr0DQmSThYHLtNCdSdXk9YkxD/jK6X2vmCyyXBBxyqZ4XcnzTyYEAThfX3DCEnLf6igw== nanoid@3.3.1: version "3.3.1" From b490e1a90ef8b192b2961cbaf324dba3662c4cec Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:03:45 -0700 Subject: [PATCH 04/10] test --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index df29bd6..4a8823a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,6 +22,8 @@ jobs: node-version: ${{ matrix.node-version }} architecture: 'x64' cache: yarn + - name: node-gyp v10 + run: npm install -g node-gyp@10.1.0 - name: Install run: yarn --frozen-lockfile - name: Lint From 737182e6491a908aef66f37eb048c08b6e10b4f0 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:08:20 -0700 Subject: [PATCH 05/10] downgrade python --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a8823a..6c8fc25 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,8 +22,9 @@ jobs: node-version: ${{ matrix.node-version }} architecture: 'x64' cache: yarn - - name: node-gyp v10 - run: npm install -g node-gyp@10.1.0 + - uses: actions/setup-python@v5 + with: + python-version: '3.2' - name: Install run: yarn --frozen-lockfile - name: Lint From 29751903eb108fa0b7bc3c380ae8b5015bde6bad Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:09:28 -0700 Subject: [PATCH 06/10] x64 python as well --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6c8fc25..cdfc8d5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,7 +24,8 @@ jobs: cache: yarn - uses: actions/setup-python@v5 with: - python-version: '3.2' + python-version: '3.2' + architecture: 'x64' - name: Install run: yarn --frozen-lockfile - name: Lint From 95e1032b9df7613f8972931efbfdd2453cafa3ea Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:10:56 -0700 Subject: [PATCH 07/10] beep boop --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cdfc8d5..8530686 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -24,7 +24,7 @@ jobs: cache: yarn - uses: actions/setup-python@v5 with: - python-version: '3.2' + python-version: '3.2.5' architecture: 'x64' - name: Install run: yarn --frozen-lockfile From 3214fcc9fc7bfc04cc5296165bd5b1f0800c9ed3 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:13:40 -0700 Subject: [PATCH 08/10] giveu p --- .github/workflows/ci.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8530686..b330b93 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,19 +13,14 @@ jobs: runs-on: macOS-latest strategy: matrix: - node-version: [12.13.0, 14.x, 16.x, 18.x, 20.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: ${{ matrix.node-version }} - architecture: 'x64' cache: yarn - - uses: actions/setup-python@v5 - with: - python-version: '3.2.5' - architecture: 'x64' - name: Install run: yarn --frozen-lockfile - name: Lint From 4cdb2612d36ed79f8bb2759bfcf786c93afeac39 Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:16:28 -0700 Subject: [PATCH 09/10] downgrade python again --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b330b93..733266f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,6 +21,9 @@ jobs: with: node-version: ${{ matrix.node-version }} cache: yarn + - uses: actions/setup-python@v5 + with: + python-version: '3.11' - name: Install run: yarn --frozen-lockfile - name: Lint From a56bd12f9f410139214bceb247ce6392efc1aaed Mon Sep 17 00:00:00 2001 From: Erick Zhao Date: Fri, 21 Jun 2024 21:27:42 -0700 Subject: [PATCH 10/10] sha + comments --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 733266f..7ddf718 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,14 +16,14 @@ jobs: node-version: [16.x, 18.x, 20.x] steps: - - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: node-version: ${{ matrix.node-version }} cache: yarn - - uses: actions/setup-python@v5 + - uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0 with: - python-version: '3.11' + python-version: '3.11' # distutils is required by node-gyp and dropped by python core in 3.12 - name: Install run: yarn --frozen-lockfile - name: Lint