Any documentation for use of (or disabling of) reclient?

[alexciarlillo]

It's been a few months since I did an electron build and I just pulled down the latest build-tools this evening. I am now getting an authentication error related to RBE. According to this it seems like even Cache-Only access is limited to Electron maintainers? If this is not actually the case I would love to know how to properly configure Cache-Only access, or otherwise how to correctly disable use of reclient.

Thanks

[alexciarlillo]

So I was able disable reclient by setting "reclient": "none" in my config but I'm still a little confused on the issue of if Cache-Only access should be working or not. What is the recommended configuration for non-maintainers?

[codebytere]

@alexciarlillo it's only within the last few weeks been enabled upstream, and we've only just gotten our deployment rolled out to maintainers courtesy of @MarshallOfSound. We'll let you know when it's more available for external contributrs but for now you should continue to use the goma cache. reclient usage also defaults to none as of cc4f6c3 - you can run e sanitize-config to make this permanent.

[alexciarlillo]

Thanks I may be reading this incorrectly but it looks as of #537 merged yesterday, specifically this change it may no longer be defaulting to none? Unfortunately I cannot remember the exact steps - if I had init'd a new config or sanitized an existing one, but I definitely hit this without any manual opt-in to use reclient.

[nikitakot]

I'm also looking for "What is the recommended configuration for non-maintainers?".

Running e init --fork nikitakot/electron develop was hanging for me on reclient auth request, even after I entered credentials in the browser (I don't have access).
Running e init --fork nikitakot/electron --reclient none develop did work, but it produces the following config with goma disabled:

{
  "$schema": "file:///c%3A/Users/Administrator/.electron_build_tools/evm-config.schema.json",
  "goma": "none",
  "reclient": "none",
  "root": "C:\\Users\\Administrator\\.electron_build_tools\\electron",
  "remotes": {
    "electron": {
      "origin": "git@github.com:electron/electron.git",
      "fork": "git@github.com:nikitakot/electron.git"
    }
  },
  "gen": {
    "args": [
      "import(\"//electron/build/args/testing.gn\")"
    ],
    "out": "Testing"
  },
  "env": {
    "CHROMIUM_BUILDTOOLS_PATH": "C:\\Users\\Administrator\\.electron_build_tools\\electron\\src\\buildtools",
    "GIT_CACHE_PATH": "C:\\Users\\Administrator\\.git_cache"
  }
}

[codebytere]

@MarshallOfSound what are your thoughts here?

[SheikhSajid]

So I was able disable reclient by setting "reclient": "none"

@alexciarlillo Hi there, sorry if this is a dumb question but where exactly did you change this config? I am a newbie to electron development and whenever I run e build, I see the following:

Authentication Status: Not Authenticated

ERROR You do not have valid auth for Reclient, please run "e d rbe login"

I am just trying to get a local build working, not even sure what reclient is.

[nikitakot]

@SheikhSajid configs are in ~/.electron_build_tools/configs

[dsanders11]

It's supposed to work for external users as well, in cache-only mode.

Can someone provide details on what happens if you run the suggested e d rbe login? Are there any errors?

[BurningEnlightenment]

@dsanders11 I don't get an "exception", but something akin to a 403 Forbidden after I login with my GitHub account:

[nikitakot]

@dsanders11 I don't get an "exception", but something akin to a 403 Forbidden after I login with my GitHub account:

same experience

[SheikhSajid]

@dsanders11 I don't get an "exception", but something akin to a 403 Forbidden after I login with my GitHub account:

This is what I am getting as well

[nikitakot]

@dsanders11

any updates? should/can non maintainers continue to use goma? during the recent builds the cache-hit dropped significantly

or switch to reclient is preferred? if reclient is preferred is there a way to authenticate in scripting environment without opening a browser window? thanks.

[dsanders11]

Hi all - we think this may be resolved now, can you try authenticating again? Non-maintainers should get cache-only access.

[BurningEnlightenment]

@dsanders11 it seems to work fine now.