`e sync` command fails due to git root mistmatch (Windows 10)

[andrewsml]

this happen by running e sync command.
it compares two pathes and the only difference is that C: drive is in uppercase

________ running 'python3 build/config/siso/configure_siso.py --rbe_instance projects/rbe-chrome-untrusted/instances/default_instance' in 'c:\workspace\electron_release'
gclient(1967) _WriteFileContents:Writing to file c:\workspace\electron_release\.gclient_previous_sync_commits
ERROR Expected git root to be c:\workspace\electron_release\src\electron but found C:\workspace\electron_release\src\electron

Operating System

Windows 10 22H2

Expected Behavior

e sync succeeds

[MarshallOfSound]

I assume we need some kind of path.normalize around cwd as well here -->

build-tools/src/e-sync.js

Lines 21 to 23 in 6cfcc75

	if (gitRoot !== cwd) {
	fatal(`Expected git root to be ${cwd} but found ${gitRoot}`);
	}

You can try fiddling with that part of build-tools locally and submit a PR if you can make it work? Build tools is working fine on my windows machine so it's probably something specific to your set up? File system, node version, git version, etc.

[andrewsml]

@MarshallOfSound , alright. I made a pull request, thanks