refactor: replace ts-node with tsx

Author: erickzhao

package.json

@@ -10,7 +10,7 @@
     "clean": "rimraf dist && lerna exec -- rimraf dist tsconfig.tsbuildinfo",
     "build": "tsc -b packages",
     "build:watch": "yarn build --watch",
-    "postbuild": "ts-node tools/test-dist",
+    "postbuild": "tsx tools/test-dist.ts",
     "docs": "yarn build && npx typedoc",
     "lerna:publish": "lerna publish --force-publish --conventional-commits --no-changelog --exact",
     "lint:js": "prettier --check . && eslint . --cache",
@@ -24,8 +24,8 @@
     "test": "xvfb-maybe vitest run --project fast --project slow",
     "test:fast": "xvfb-maybe vitest run --project fast",
     "test:slow": "xvfb-maybe vitest run --project slow",
-    "test:clear": "ts-node tools/test-clear",
-    "postinstall": "rimraf node_modules/.bin/*.ps1 && ts-node ./tools/gen-tsconfigs.ts && ts-node ./tools/gen-ts-glue.ts",
+    "test:clear": "tsx tools/test-clear.ts",
+    "postinstall": "rimraf node_modules/.bin/*.ps1 && tsx ./tools/gen-tsconfigs.ts && tsx ./tools/gen-ts-glue.ts",
     "prepare": "husky install",
     "preversion": "yarn build"
   },
@@ -70,6 +70,7 @@
     "semver": "^7.2.1",
     "source-map-support": "^0.5.13",
     "sudo-prompt": "^9.1.1",
+    "tsx": "^4.19.3",
     "username": "^5.1.0",
     "vite": "^5.0.12",
     "webpack": "^5.69.1",
@@ -119,7 +120,6 @@
     "prettier": "^2.4.0",
     "rimraf": "^3.0.1",
     "syncpack": "^11.2.1",
-    "ts-node": "^10.0.0",
     "typedoc": "0.25.13",
     "typescript": "~5.4.5",
     "vitest": "^3.0.3",

packages/api/core/package.json

@@ -60,6 +60,7 @@
     "semver": "^7.2.1",
     "source-map-support": "^0.5.13",
     "sudo-prompt": "^9.1.1",
+    "tsx": "^4.19.3",
     "username": "^5.1.0"
   },
   "engines": {

packages/api/core/src/util/forge-config.ts

@@ -6,13 +6,24 @@ import * as interpret from 'interpret';
 import { template } from 'lodash';
 import * as rechoir from 'rechoir';
 
-// eslint-disable-next-line n/no-missing-import
-import { dynamicImportMaybe } from '../../helper/dynamic-import.js';
+import { dynamicImportMaybe } from '../../helper/dynamic-import';
 
 import { runMutatingHook } from './hook';
 import PluginInterface from './plugin-interface';
 import { readRawPackageJson } from './read-package-json';
 
+/* eslint-disable @typescript-eslint/no-require-imports */
+// TSX imports only work with Node16 resolution while we're still on CommonJS resolution in tsconfig.base.json
+// However, all of Vite's entire TS types break when using CommonJS with Node16 resolution, it's more approachable
+// to use `require` directly for the time being.
+const tsxCJS = require('tsx/cjs/api');
+const tsxESM = require('tsx/esm/api');
+/* eslint-enable @typescript-eslint/no-require-imports */
+
+// Register tsx enhancements
+const unregisterCJS = tsxCJS.register();
+const unregisterESM = tsxESM.register();
+
 const underscoreCase = (str: string) =>
   str
     .replace(/(.)([A-Z][a-z]+)/g, '$1_$2')
@@ -130,7 +141,7 @@ export default async (dir: string): Promise<ResolvedForgeConfig> => {
   }
 
   if (!forgeConfig || typeof forgeConfig === 'string') {
-    for (const extension of ['.js', ...Object.keys(interpret.extensions)]) {
+    for (const extension of ['.js', ...Object.keys(interpret.extensions).filter((ext) => ext !== '.ts')]) {
       const pathToConfig = path.resolve(dir, `forge.config${extension}`);
       if (await fs.pathExists(pathToConfig)) {
         rechoir.prepare(interpret.extensions, pathToConfig, dir);
@@ -176,5 +187,8 @@ export default async (dir: string): Promise<ResolvedForgeConfig> => {
 
   resolvedForgeConfig = await runMutatingHook(resolvedForgeConfig, 'resolveForgeConfig', resolvedForgeConfig);
 
+  unregisterCJS();
+  unregisterESM();
+
   return proxify<ResolvedForgeConfig>(resolvedForgeConfig.buildIdentifier || '', resolvedForgeConfig, 'ELECTRON_FORGE');
 };

packages/template/vite-typescript/tmpl/package.json

@@ -5,7 +5,6 @@
     "@typescript-eslint/parser": "^5.0.0",
     "eslint": "^8.0.1",
     "eslint-plugin-import": "^2.25.0",
-    "ts-node": "^10.0.0",
     "typescript": "~4.5.4",
     "vite": "^5.0.12"
   }

packages/template/webpack-typescript/tmpl/package.json

@@ -11,7 +11,6 @@
     "node-loader": "^2.0.0",
     "style-loader": "^3.0.0",
     "ts-loader": "^9.2.2",
-    "ts-node": "^10.0.0",
     "typescript": "~4.5.4"
   }
 }