cache it instead

Author: erickzhao

packages/utils/core-utils/src/package-manager.ts

@@ -6,11 +6,11 @@ import logSymbols from 'log-symbols';
 
 const d = debug('electron-forge:package-manager');
 
-let hasEmittedWarning = false;
-
 export type SupportedPackageManager = 'yarn' | 'npm' | 'pnpm';
 export type PMDetails = { executable: SupportedPackageManager; version?: string; install: string; dev: string; exact: string };
 
+let cachedPM: PMDetails | undefined = undefined;
+
 const MANAGERS: Record<SupportedPackageManager, PMDetails> = {
   yarn: {
     executable: 'yarn',
@@ -71,15 +71,18 @@ function pmFromUserAgent() {
  *
  */
 export const resolvePackageManager: () => Promise<PMDetails> = async () => {
+  if (cachedPM) {
+    return cachedPM;
+  }
+
   const executingPM = pmFromUserAgent();
   const lockfile = await findUp(['package-lock.json', 'yarn.lock', 'pnpm-lock.yaml', 'pnpm-workspace.yaml'], { type: 'file' });
   const lockfilePM = (lockfile && PM_FROM_LOCKFILE[lockfile]) ?? undefined;
   const installer = process.env.NODE_INSTALLER || executingPM?.name || lockfilePM;
 
   // TODO(erickzhao): Remove NODE_INSTALLER environment variable for Forge 8
-  if (typeof process.env.NODE_INSTALLER === 'string' && !hasEmittedWarning) {
+  if (typeof process.env.NODE_INSTALLER === 'string') {
     console.warn(logSymbols.warning, chalk.yellow(`The NODE_INSTALLER environment variable is deprecated and will be removed in Electron Forge v8`));
-    hasEmittedWarning = true;
   }
 
   switch (installer) {
@@ -89,7 +92,8 @@ export const resolvePackageManager: () => Promise<PMDetails> = async () => {
       d(
         `Resolved package manager to ${installer}. (Derived from NODE_INSTALLER: ${process.env.NODE_INSTALLER}, npm_config_user_agent: ${executingPM}, lockfile: ${lockfilePM}.)`
       );
-      return { ...MANAGERS[installer], version: executingPM?.version };
+      cachedPM = { ...MANAGERS[installer], version: executingPM?.version };
+      break;
     default:
       if (installer !== undefined) {
         console.warn(
@@ -99,8 +103,9 @@ export const resolvePackageManager: () => Promise<PMDetails> = async () => {
       } else {
         d(`No package manager detected. Falling back to npm.`);
       }
-      return MANAGERS['npm'];
+      cachedPM = MANAGERS['npm'];
   }
+  return cachedPM;
 };
 
 export const spawnPackageManager = async (args?: CrossSpawnArgs, opts?: CrossSpawnOptions): Promise<string> =>