Skip to content

In WIX MSI mode, appIconPath cannot be set in package.json #2547

Open
@17radix

Description

@17radix

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

I have already browsed https://js.electronforge.io/maker/wix/interfaces/makerwixconfig

After I generated my program and installed it, my icon is not consistent with the actual one

Like this:
image

appIconPath cannot be set in package.json

Proposed solution

add appIconPath to MSICreatorOptions (packages/maker/wix/src/Config.ts)

Alternatives considered

1、It can be set using JavaScript script, but it is not easy to maintain
2、It may be possible to automatically set this value to {packagerConfig.icon}, but it may cause incompatibility with old projects, so it is not recommended
"packagerConfig": {
"icon":"favicon.ico"
},

Additional information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions