Skip to content

maker-deb config.depends has no effect #3127

Open
@NemoAlex

Description

@NemoAlex

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.4

Electron version

18.3.6

Operating system

Linux x64

Last known working Electron Forge version

No response

Expected behavior

config.depends should work.

Actual behavior

config.depends not working.

Steps to reproduce

forge.config.js:

  makers: [
    {
      name: '@electron-forge/maker-deb',
      config: {
        depends: ['libopencv-dev']
      }
    }
  ]

Additional information

Looks like the problem is here:
https://github.com/electron/forge/blob/main/packages/maker/deb/src/MakerDeb.ts#L42
https://github.com/electron-userland/electron-installer-debian/blob/main/src/installer.js#L173
https://github.com/electron-userland/electron-installer-common/blob/master/src/dependencies.js#L126
Here leaves an empty options object during initialization.
This makes the merge option use empty content.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions