MSI build generated from electron-forge does not sign the app executable files

[neel-dedhia]

Pre-flight checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project uses.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.4

Electron version

27.0.0

Operating system

Windows 11 Pro

Last known working Electron Forge version

none

Expected behavior

The application when installed from MSI installer, should have all executables signed.

Actual behavior

MSI installed is signed but post installation of the application the executables inside the app are not signed.

Steps to reproduce

Create an electron project, pass the signWithParams config in electron forge for maker wix:
{ makers: [ { name: '@electron-forge/maker-wix', config: { language: 1033, manufacturer: 'Hello App Inc.', version, rebootMode: 'Suppress', name: 'Hello App', appIconPath: '/path/to/icon', appUserModelId: 'Hello App', upgradeCode: 'UUID', programFilesFolderName: '/path/to/install/directory', features: { autoUpdate: true, autoLaunch: true, }, beforeCreate: (config) => { /** * We are adding this step to create uninstall.exe file in the application installation directory */ config.wixTemplate = createUninstallShortcut(config.wixTemplate); }, installLevel: 3, ui: false, signWithParams: '/tr http://timestamp.digicert.com /td sha256 /fd sha256 /a /d "hello-app.msi"' }, } ] }

Additional information

No response

[VerteDinde]

Thanks for reporting this issue. You need to sign both the installer and the underlying executables in order for an MSI to be fully signed. Would it be possible for you to make a more detailed standalone testcase with only the code necessary to reproduce the issue, and we can see if that signing is working? Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

I'm adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment.

Thanks in advance!