From 64f4772a9425415f9e8c1552fb4d16855ec944d0 Mon Sep 17 00:00:00 2001 From: Samuel Maddock Date: Thu, 30 Jan 2025 18:05:48 -0500 Subject: [PATCH 1/4] docs: stale PR response --- playbooks/responses/stale-pr.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 playbooks/responses/stale-pr.md diff --git a/playbooks/responses/stale-pr.md b/playbooks/responses/stale-pr.md new file mode 100644 index 000000000..34dbf0299 --- /dev/null +++ b/playbooks/responses/stale-pr.md @@ -0,0 +1,19 @@ +--- +action: + - add 'stale' label + - close pull request +--- + +Thank you for your contribution to the project! + +We apologize for the delay in reviewing your pull request. In the time since it +was opened, there have been many changes to the codebase, and it's possible that +your pull request is no longer applicable or conflicts with more recent updates. + +To keep pull requests relevant to maintainers, we'll be closing this pull +request for now. However, if you believe the pull request is still relevant or +if there was a mistake, feel free to request us to reopen it or provide a +follow-up comment. + +If you wish to continue pursuing your contribution, please update your branch +with the latest changes on `main` and resolve any existing conflicts. From 99d71554b2c3802b9ede0200c6ab2aeda40e618f Mon Sep 17 00:00:00 2001 From: Samuel Maddock Date: Fri, 31 Jan 2025 10:11:01 -0500 Subject: [PATCH 2/4] reword --- playbooks/responses/stale-pr.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/playbooks/responses/stale-pr.md b/playbooks/responses/stale-pr.md index 34dbf0299..e51bc720c 100644 --- a/playbooks/responses/stale-pr.md +++ b/playbooks/responses/stale-pr.md @@ -4,16 +4,16 @@ action: - close pull request --- -Thank you for your contribution to the project! +Thank you for your contribution to Electron! -We apologize for the delay in reviewing your pull request. In the time since it -was opened, there have been many changes to the codebase, and it's possible that -your pull request is no longer applicable or conflicts with more recent updates. +We've noticed there hasn't been any activity from the author in some time, and +since the pull request was opened, there have been many changes to the codebase. +As a result, your pull request may no longer be applicable or could conflict +with more recent updates. -To keep pull requests relevant to maintainers, we'll be closing this pull -request for now. However, if you believe the pull request is still relevant or -if there was a mistake, feel free to request us to reopen it or provide a -follow-up comment. +To keep pull requests relevant for maintainers, we'll be closing this one for +now. However, if you believe it's still relevant or if there was a mistake, feel +free to request us to reopen it or provide a follow-up comment. -If you wish to continue pursuing your contribution, please update your branch -with the latest changes on `main` and resolve any existing conflicts. +If you'd like to continue with your contribution, please update your branch +with the latest changes from `main` and resolve any conflicts. From be30c879e30b874ae8ada63cabe0fc836485c857 Mon Sep 17 00:00:00 2001 From: Samuel Maddock Date: Fri, 31 Jan 2025 12:25:40 -0500 Subject: [PATCH 3/4] remove line breaks so it's easier to copy --- playbooks/responses/stale-pr.md | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/playbooks/responses/stale-pr.md b/playbooks/responses/stale-pr.md index e51bc720c..f8b924936 100644 --- a/playbooks/responses/stale-pr.md +++ b/playbooks/responses/stale-pr.md @@ -6,14 +6,8 @@ action: Thank you for your contribution to Electron! -We've noticed there hasn't been any activity from the author in some time, and -since the pull request was opened, there have been many changes to the codebase. -As a result, your pull request may no longer be applicable or could conflict -with more recent updates. +We've noticed there hasn't been any activity from the author in some time, and since the pull request was opened, there have been many changes to the codebase. As a result, your pull request may no longer be applicable or could conflict with more recent updates. -To keep pull requests relevant for maintainers, we'll be closing this one for -now. However, if you believe it's still relevant or if there was a mistake, feel -free to request us to reopen it or provide a follow-up comment. +To keep pull requests relevant for maintainers, we'll be closing this one for now. However, if you believe it's still relevant or if there was a mistake, feel free to request us to reopen it or provide a follow-up comment. -If you'd like to continue with your contribution, please update your branch -with the latest changes from `main` and resolve any conflicts. +If you'd like to continue with your contribution, please update your branch with the latest changes from `main` and resolve any conflicts. From 02a0a193db660eb6299b6c4500bb25615344d311 Mon Sep 17 00:00:00 2001 From: Sam Maddock Date: Fri, 31 Jan 2025 12:58:24 -0500 Subject: [PATCH 4/4] Update playbooks/responses/stale-pr.md Co-authored-by: Erick Zhao --- playbooks/responses/stale-pr.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/responses/stale-pr.md b/playbooks/responses/stale-pr.md index f8b924936..d0fb12498 100644 --- a/playbooks/responses/stale-pr.md +++ b/playbooks/responses/stale-pr.md @@ -6,7 +6,7 @@ action: Thank you for your contribution to Electron! -We've noticed there hasn't been any activity from the author in some time, and since the pull request was opened, there have been many changes to the codebase. As a result, your pull request may no longer be applicable or could conflict with more recent updates. +We've noticed there hasn't been any activity on the pull request in some time, and there have been many changes to the codebase since it was opened. As a result, your pull request may no longer be applicable or could conflict with more recent updates. To keep pull requests relevant for maintainers, we'll be closing this one for now. However, if you believe it's still relevant or if there was a mistake, feel free to request us to reopen it or provide a follow-up comment.