Skip to content

Commit 4e3ab8a

Browse files
build: do CFA releases (#1566)
* build: do CFA releases * chore: prepare for package and repo rename * build: always pull x64 darwin build * downgrade --------- Co-authored-by: Samuel Attard <[email protected]> Co-authored-by: Samuel Attard <[email protected]>
1 parent b21ea52 commit 4e3ab8a

21 files changed

+1814
-171
lines changed

.circleci/config.yml

+11-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
version: 2.1
22

33
orbs:
4-
node: electronjs/[email protected]
4+
cfa: continuousauth/[email protected]
5+
node: electronjs/[email protected]
56

67
jobs:
78
test:
@@ -21,6 +22,7 @@ jobs:
2122
- node/test:
2223
post-node-js-install-steps:
2324
- run: test/ci/before_install.sh
25+
override-ci-command: yarn install --frozen-lockfile --ignore-engines
2426
test-steps:
2527
- restore_cache:
2628
name: Restoring Electron cache
@@ -63,4 +65,11 @@ workflows:
6365
- 16.4.0
6466
filters:
6567
branches: { ignore: gh-pages }
66-
68+
- cfa/release:
69+
requires:
70+
- test
71+
filters:
72+
branches:
73+
only:
74+
- main
75+
context: cfa-release

.github/ISSUE_TEMPLATE/bug.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ labels: "bug :bug:"
77
### Preflight Checklist
88
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
99

10-
* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
10+
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
1111
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
1212
* [ ] I have searched the issue tracker for a bug that matches the one I want to file, without success.
1313

.github/ISSUE_TEMPLATE/feature_request.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ labels: "enhancement"
77
### Preflight Checklist
88
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
99

10-
* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
10+
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
1111
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
1212
* [ ] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
1313

.github/config.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
# Comment to be posted to on first time issues
44
newIssueWelcomeComment: |
5-
👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the [support docs](https://github.com/electron/electron-packager/blob/main/SUPPORT.md). If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.
5+
👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the [support docs](https://github.com/electron/packager/blob/main/SUPPORT.md). If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.
66
7-
To help make it easier for us to investigate your issue, please follow the [contributing guidelines](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md#before-opening-bug-reportstechnical-issues).
7+
To help make it easier for us to investigate your issue, please follow the [contributing guidelines](https://github.com/electron/packager/blob/main/CONTRIBUTING.md#before-opening-bug-reportstechnical-issues).
88
99
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome
1010

@@ -13,7 +13,7 @@ newPRWelcomeComment: |
1313
Thanks for opening a pull request!
1414
1515
Here are some highlighted action items that will help get it across the finish line, from the
16-
[pull request guidelines](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md#filing-pull-requests):
16+
[pull request guidelines](https://github.com/electron/packager/blob/main/CONTRIBUTING.md#filing-pull-requests):
1717
- Follow the [JavaScript coding style](https://standardjs.com/).
1818
- Run `npm run lint` locally to catch formatting errors earlier.
1919
- Document any user-facing changes in `NEWS.md` and other docs.

.github/pull_request_template.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Thanks for filing a pull request!
33
Please check off all of the steps as they are completed by replacing [ ] with [x].
44
-->
55

6-
* [ ] I have read the [contribution documentation](https://github.com/electron/electron-packager/blob/main/CONTRIBUTING.md) for this project.
6+
* [ ] I have read the [contribution documentation](https://github.com/electron/packager/blob/main/CONTRIBUTING.md) for this project.
77
* [ ] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project follows, as appropriate.
88
* [ ] The changes are appropriately documented (if applicable).
99
* [ ] The changes have sufficient test coverage (if applicable).

.github/workflows/canary.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Install Electron Packager
3131
run: |
3232
cd electron-quick-start
33-
npm install --save-dev electron-packager@electron/electron-packager
33+
npm install --save-dev @electron/packager@electron/packager
3434
shell: bash
3535
- name: Package
3636
run: |

.releaserc.json

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"plugins": [
3+
"@semantic-release/commit-analyzer",
4+
"@semantic-release/release-notes-generator",
5+
"@continuous-auth/semantic-release-npm",
6+
"@semantic-release/github"
7+
],
8+
"branches": ["main"]
9+
}

CONTRIBUTING.md

+2-13
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Electron Packager is a community-driven project. As such, we welcome and encoura
44
contributions. They include, but are not limited to:
55

66
- Constructive feedback
7-
- [Questions about usage](https://github.com/electron/electron-packager/blob/main/SUPPORT.md)
7+
- [Questions about usage](https://github.com/electron/packager/blob/main/SUPPORT.md)
88
- [Bug reports / technical issues](#before-opening-bug-reportstechnical-issues)
99
- Documentation changes
1010
- Feature requests
@@ -41,7 +41,7 @@ messages when a script errors.**
4141

4242
## Contribution suggestions
4343

44-
We use the label [`help wanted`](https://github.com/electron/electron-packager/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) in the issue tracker to denote fairly-well-scoped-out bugs or feature requests that the community can pick up and work on. If any of those labeled issues do not have enough information, please feel free to ask constructive questions. (This applies to any open issue.)
44+
We use the label [`help wanted`](https://github.com/electron/packager/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) in the issue tracker to denote fairly-well-scoped-out bugs or feature requests that the community can pick up and work on. If any of those labeled issues do not have enough information, please feel free to ask constructive questions. (This applies to any open issue.)
4545

4646
## Filing Pull Requests
4747

@@ -124,14 +124,3 @@ existing fixture, such as `basic`. If you need to add a new fixture:
124124
## For Collaborators
125125

126126
Make sure to get a `:thumbsup:`, `+1` or `LGTM` from another collaborator before merging a PR.
127-
128-
### Release process
129-
130-
- if you aren't sure if a release should happen, open an issue
131-
- make sure that `NEWS.md` is up to date
132-
- make sure the tests pass
133-
- `npm version <major|minor|patch>`
134-
- `git push && git push --tags` (or `git push` with `git config --global push.followTags true` on latest git)
135-
- create a new GitHub release from the pushed tag with the contents of `NEWS.md` for that version
136-
- close the milestone associated with the version if one is open
137-
- `npm publish`

0 commit comments

Comments
 (0)