Linting...

Author: elegos

pyproject.toml

@@ -25,6 +25,7 @@ dependencies = [
 [dependency-groups]
 dev = [
     "basedpyright>=1.39.0",
+    "pyside6-stubs>=6.7.3.0",
     "pytest>=9.0.3",
     "pytest-cov>=7.1.0",
 ]

pyrightconfig.json

@@ -1,5 +1,7 @@
 {
-  "exclude": ["src/georeel/core/blender_scripts", "tests"],
+  "exclude": [".venv", "**/node_modules", "**/__pycache__", "**/.*", "src/georeel/core/blender_scripts", "tests"],
   "reportImplicitStringConcatenation": false,
   "reportUnusedCallResult": false,
+  "venvPath": ".",
+  "venv": ".venv"
 }

src/georeel/core/bounding_box.py

@@ -1,5 +1,6 @@
 import math
 from dataclasses import dataclass
+from typing import override
 
 _M_PER_DEG_LAT = 111_320.0
 
@@ -23,6 +24,7 @@ def expand(self, margin_m: float) -> "BoundingBox":
             max_lon=self.max_lon + lon_delta,
         )
 
+    @override
     def __str__(self) -> str:
         return (
             f"({self.min_lat:.5f}, {self.min_lon:.5f}) → "

src/georeel/core/camera_path.py

@@ -40,9 +40,6 @@ def _rss_mb() -> float:
         return float("nan")
 
 
-def _mem(label: str) -> None:
-    _log.debug("[camera_path mem] %s — RSS %.0f MB", label, _rss_mb())
-
 # Douglas-Peucker tolerance (metres).  Points closer than this to the
 # straight line between their neighbours are removed.
 _DP_EPSILON_M = 20.0
@@ -471,25 +468,6 @@ def _douglas_peucker(pts: np.ndarray, epsilon: float) -> np.ndarray:
 # ------------------------------------------------------------------
 
 
-def _height_at(
-    x: float,
-    y: float,
-    grid: ElevationGrid,
-    bbox: BoundingBox,
-    lat_m: float,
-    lon_m: float,
-    height_mode: str,
-    height_offset: float,
-) -> float:
-    lat = bbox.min_lat + y / lat_m * (bbox.max_lat - bbox.min_lat)
-    lon = bbox.min_lon + x / lon_m * (bbox.max_lon - bbox.min_lon)
-    if height_mode == "dem_smooth":
-        elev = _smooth_elevation(grid, lat, lon)
-    else:
-        elev = grid.elevation_at(lat, lon)
-    return elev + height_offset
-
-
 def _height_at_batch(
     xs: np.ndarray,
     ys: np.ndarray,
@@ -515,18 +493,6 @@ def _height_at_batch(
     return grid.elevation_at_batch(lats, lons)
 
 
-def _smooth_elevation(grid: ElevationGrid, lat: float, lon: float) -> float:
-    """Mean elevation over a 3×3 neighbourhood (1.5× grid spacing)."""
-    dlat = (grid.max_lat - grid.min_lat) / (grid.rows - 1) * 1.5
-    dlon = (grid.max_lon - grid.min_lon) / (grid.cols - 1) * 1.5
-    samples = [
-        grid.elevation_at(lat + r * dlat, lon + c * dlon)
-        for r in (-1, 0, 1)
-        for c in (-1, 0, 1)
-    ]
-    return sum(samples) / len(samples)
-
-
 # ------------------------------------------------------------------
 # Orientation helpers
 # ------------------------------------------------------------------

src/georeel/core/dem_fetcher.py

@@ -154,7 +154,7 @@ def _load(tile_lat: int, tile_lon: int) -> tuple[int, int, object]:
         futures = {pool.submit(_load, tlat, tlon): (tlat, tlon)
                    for tlat, tlon in all_tiles}
         for future in as_completed(futures):
-            tile_lat, tile_lon, geo_file = future.result()
+            _, _, geo_file = future.result()
 
             tiles_done += 1
             if progress_callback is not None:

src/georeel/core/frame_renderer.py

@@ -22,7 +22,7 @@
 import threading
 from concurrent.futures import Future, ThreadPoolExecutor
 from pathlib import Path
-from typing import Any, Callable
+from typing import Any, Callable, final
 
 from PIL import Image as _PILImage
 
@@ -39,6 +39,7 @@ class FrameRenderError(Exception):
     pass
 
 
+@final
 class _CompressionServer:
     """Listens on a localhost TCP port; Blender sends a PNG path (newline-
     terminated) after each frame is written.  A thread pool re-compresses
@@ -205,7 +206,7 @@ def render_frames(
     n_segments = int(settings.get("render/n_segments", 1))
 
     work_dir = temp_manager.make_temp_dir("georeel_frames_")
-    pipeline._temp_dirs.append(work_dir)
+    pipeline.temp_dirs.append(work_dir)
     kf_path  = work_dir / "keyframes.json"
     out_dir  = work_dir / "frames"
     out_dir.mkdir()

src/georeel/core/frustum.py

@@ -28,7 +28,6 @@ def frustum_margin(height_m: float, tilt_deg: float,
     any direction along the track, so the margin is applied uniformly.
     """
     # Vertical FOV for the 16:9 sensor/lens combination
-    2 * math.atan(_SENSOR_W_MM / 2 / _FOCAL_MM)
     vfov = 2 * math.atan(_SENSOR_W_MM / _ASPECT / 2 / _FOCAL_MM)
 
     # Angle below horizontal of the top edge of the frame

src/georeel/core/gpx_parser.py

@@ -44,7 +44,7 @@ def _fix_undeclared_namespaces(content: str) -> str:
     if not missing:
         return content
 
-    injections = []
+    injections: list[str] = []
     for prefix in sorted(missing):
         uri = _KNOWN_NS.get(prefix, f"urn:unknown-ns:{prefix}")
         injections.append(f'xmlns:{prefix}="{uri}"')

src/georeel/core/photo_compositor.py

@@ -161,7 +161,7 @@ def composite_photos(
     out_w, out_h = _RESOLUTIONS.get(resolution, (1920, 1080))
 
     comp_work_dir = temp_manager.make_temp_dir("georeel_comp_")
-    pipeline._temp_dirs.append(comp_work_dir)
+    pipeline.temp_dirs.append(comp_work_dir)
     out_dir = comp_work_dir / "frames"
     out_dir.mkdir()
 

src/georeel/core/pipeline.py

@@ -71,10 +71,10 @@ class Pipeline:
     # Large intermediate dirs (frame sequences) are registered here so
     # they can be removed as soon as the job finishes or is cancelled.
     # ------------------------------------------------------------------ #
-    _temp_dirs: list[Path] = field(default_factory=list, repr=False)
+    temp_dirs: list[Path] = field(default_factory=list, repr=False)
 
     def cleanup(self) -> None:
         """Delete all registered temporary directories."""
-        for d in list(self._temp_dirs):
+        for d in list(self.temp_dirs):
             shutil.rmtree(d, ignore_errors=True)
-        self._temp_dirs.clear()
+        self.temp_dirs.clear()