Merge pull request #261 from element-hq/gaelg/ci-ct-lint

ct-lint.sh: parse $ / $root

Author: gaelgatelement

.github/workflows/build-test.yml

@@ -62,13 +62,6 @@ jobs:
         git config --global --add safe.directory "$GITHUB_WORKSPACE"
         bash scripts/ct-lint.sh --config ct.yaml
 
-    - name: Ensure we don't use the helm $ root token in .tpl files
-      shell: bash
-      run: |
-        find . -type f -name '*.tpl' -exec grep -E '\{\{[^}]*\$[^a-zA-Z0-9_][^}]*\}\}' {} + && {
-          echo 'Error: $ is used in a .tpl files, but helm passes the local context to the special variable $ in included templates.'; exit 1 
-        } || echo "OK."
-
     - uses: matrix-org/setup-python-poetry@gaelg/poetry-venv
       with:
         poetry-version: "1.8.5"

newsfragments/261.internal.md

@@ -0,0 +1 @@
+ct-lint.sh : Run the check about $ forbidden in .tpl files.

scripts/ct-lint.sh

@@ -10,6 +10,10 @@ temp_output_file=$(mktemp)
 
 error=1
 
+find . -type f -name '*.tpl' -exec grep -E '\{\{[^}]*\$[^a-zA-Z0-9_][^}]*\}\}' {} + && {
+  echo 'Error: $ is used in a .tpl files, but helm passes the local context to the special variable $ in included templates.'; exit 1 
+} || echo "OK."
+
 # Call the ct lint command and stream the output to stdout
 if ct lint "$@" 2>&1 | tee "$temp_output_file"
 then