Skip to content

Commit cdf286d

Browse files
authored
Use uv to test full set of minimum deps in CI (#19289)
Stemming from #19274 this updates the `olddeps` CI to test against not just the minimum version of our explicit dependencies, but also the minimum version of all implicit (transitive) dependencies that are pulled in from the explicit dependencies themselves. ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
1 parent 3aaa2e8 commit cdf286d

File tree

5 files changed

+141
-80
lines changed

5 files changed

+141
-80
lines changed

.ci/scripts/prepare_old_deps.sh

Lines changed: 0 additions & 39 deletions
This file was deleted.

.github/workflows/tests.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -452,14 +452,12 @@ jobs:
452452
python-version: '3.10'
453453

454454
- name: Prepare old deps
455-
if: steps.cache-poetry-old-deps.outputs.cache-hit != 'true'
456-
run: .ci/scripts/prepare_old_deps.sh
457-
458-
# Note: we install using `pip` here, not poetry. `poetry install` ignores the
459-
# build-system section (https://github.com/python-poetry/poetry/issues/6154), but
460-
# we explicitly want to test that you can `pip install` using the oldest version
461-
# of poetry-core and setuptools-rust.
462-
- run: pip install .[all,test]
455+
# Note: we install using `uv` here, not poetry or pip to allow us to test with the
456+
# minimum version of all dependencies, both those explicitly specified and those
457+
# implicitly brought in by the explicit dependencies.
458+
run: |
459+
pip install uv
460+
uv pip install --system --resolution=lowest .[all,test]
463461
464462
# We nuke the local copy, as we've installed synapse into the virtualenv
465463
# (rather than use an editable install, which we no longer support). If we

changelog.d/19289.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Use `uv` to test olddeps to ensure all transitive dependencies use minimum versions.

0 commit comments

Comments
 (0)