Skip to content

Runtime errors occur when importing Glyph or FormIconField components #220

@acampbellb

Description

@acampbellb

This issue appears to be due to a change to export within Octicons.js. Previously, the export was as follows..

module.exports = {
list: list,
keys: pluck(list, 'value'),
map: map
};

It has since been changed to..

export const Octicon = {
list: list,
keys: pluck(list, 'value'),
map: map
};

Therefore, changes are required in the Glyph.js and FormIconField.js source files to accommodate the extra object level that was introduced (Octicon).

  1. Elemental\components\FormIconField.js

from:
const ICON_MAP = require('../Octicons').map;
const ICON_KEYS = require('../Octicons').keys;
to:
const ICON_MAP = require('../Octicons').Octicon.map;
const ICON_KEYS = require('../Octicons').Octicon.keys;

  1. Elemental\components\Glyph.js

from:
const icons = require('../Octicons').map;
const validNames = require('../Octicons').keys;
to:
const icons = require('../Octicons').Octicon.map;
const validNames = require('../Octicons').Octicon.keys;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions