-
-
Notifications
You must be signed in to change notification settings - Fork 56
Create io.elementary.goaltracker.json #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
danirabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your app submission! There's a few issues here that need to be resolved before it can be published:
-
Your application ID needs to reflect a URL that you have permission to write to. It can't start with "io.elementary". If you have a website it can reflect your website, otherwise it can reflect the url of your GitHub project page like
io.github.alexxisaapps.elementary_goal_tracker. See also: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic -
It looks like your app is using the Adwaita stylesheet. It must use the elementary stylesheet to be published in AppCenter. You can make sure that the Adwaita stylesheet isn't loaded by calling
Granite.init ()beforeAdw.init ()during your app's startup -
your app requests some file system permissions it shouldn't have. You have hardcoded some file paths in your app instead of getting the correct paths inside of your app's sandbox. You should use GLib to get the correct paths. See also: https://valadoc.org/glib-2.0/GLib.Environment.get_user_data_dir.html and related functions
-
Your application should add its stylesheet as a custom resource instead of installing it to the filesystem. See this documentation section on custom resources: https://docs.elementary.io/develop/apis/gresource.
Granite.init ()will automatically load a resourced stylesheet named "Application.css"
Thanks again and please feel free to join our Discord and ask for more help if anything is unclear: https://discord.gg/pCenUBu
|
Hey! Thanks for the feedback. Hopefully, it is better this time. I've implemented all the requested changes in version 1.1.0:
The release can be found here: https://github.com/alexxisaaps/elementary-goal-tracker/releases/tag/v1.1.0 Please let me know if any other changes are needed. |
|
@alexxisaaps Sorry for the long time since someone has looked at this. Since you updated the app to use the elementary stylesheet with Granite you should update the screenshots to reflect this! |
New App Submission: Goal Tracker
A simple and elegant goal-tracking application built with GTK4 for elementary OS.
App Details
Features
Review Checklist
AppData
Flatpak