Duplicate background apps

[danirabbit]

What Happened?

I've got doubles for some background apps like Steam and Discord

Steps to Reproduce

Open Steam or Discord and run in the background:

Expected Behavior

We should make sure to filter duplicates

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland)

Software Version

Compiled from git

Log Output

Hardware Info

No response

[leolost2605]

I'm pretty sure this is not a dock issue because all we do is that everytime the background apps of the monitor change we completely replace the apps in our listmodel with the new ones and that listmodel is directly bound to the listbox. But I might have missed something of course

[leolost2605]

@danirabbit you could check the dbus interface org.freedesktop.background.Monitor and there the backgroundapps property via d spy or something and check if those apps have indeed duplicate entries there. In that case this is expected behavior. (It is of course debatable whether we should merge such duplicate entries somehow but IMO this would probably bring more problems than it solves)

[danirabbit]

Yeah it looks like D-spy does give duplicate entries:

[{'app_id': <'com.valvesoftware.Steam'>, 'instance': <'2844241366'>}, {'app_id': <'com.discordapp.Discord'>, 'instance': <'3353609753'>}, {'app_id': <'com.discordapp.Discord'>, 'instance': <'3023574072'>}, {'app_id': <'com.valvesoftware.Steam'>, 'instance': <'3711042841'>}]

We should probably still de-duplicate the icons in the icongroup as in #493. For the rows themselves I agree we need to have both if these are truly separate instances which according to the dbus interface they are. I wonder if there's something we can do though to make it clear that this isn't a bug and is in fact a different instance in some way. Like if there isn't a background reason maybe showing the instance number there instead. That's kind of icky but better than it looking like we messed up