ShellClients: Reveal smoothly when starting

Author: leolost2605

src/ShellClients/PanelWindow.vala

@@ -37,6 +37,7 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
 
     private int width = -1;
     private int height = -1;
+    private bool starting = true;
 
     public PanelWindow (WindowManager wm, Meta.Window window, Pantheon.Desktop.Anchor anchor) {
         Object (wm: wm, window: window, anchor: anchor);
@@ -119,6 +120,10 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
     }
 
     protected override double get_hidden_progress () {
+        if (starting) {
+            return user_gesture_controller.progress;
+        }
+
         var user_workspace_hidden_progress = double.min (
             user_gesture_controller.progress,
             workspace_gesture_controller.progress
@@ -134,13 +139,18 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
     public override void propagate (GestureTarget.UpdateType update_type, GestureAction action, double progress) {
         workspace_hide_tracker.update (update_type, action, progress);
         base.propagate (update_type, action, progress);
+
+        if (starting && update_type == END && action == CUSTOM) {
+            // We were shown for the first time, so we can leave the special starting state
+            starting = false;
+        }
     }
 
     private void hide () {
         user_gesture_controller.goto (1);
     }
 
-    private void show () {
+    public void show () {
         user_gesture_controller.goto (0);
     }
 

src/ShellClients/ShellClientsManager.vala

@@ -25,6 +25,8 @@ public class Gala.ShellClientsManager : Object, GestureTarget {
     private NotificationsClient notifications_client;
     private ManagedClient[] protocol_clients = {};
 
+    private int starting_panels = 0;
+
     private GLib.HashTable<Meta.Window, PanelWindow> panel_windows = new GLib.HashTable<Meta.Window, PanelWindow> (null, null);
     private GLib.HashTable<Meta.Window, ShellWindow> positioned_windows = new GLib.HashTable<Meta.Window, ShellWindow> (null, null);
 
@@ -43,6 +45,8 @@ public class Gala.ShellClientsManager : Object, GestureTarget {
                 parse_mutter_hints (window);
             });
         }
+
+        Timeout.add_seconds_once (5, on_failsafe_timeout);
     }
 
     private async void start_clients () {
@@ -103,6 +107,19 @@ public class Gala.ShellClientsManager : Object, GestureTarget {
                 warning ("Failed to load launch args for client %s: %s", group, e.message);
             }
         }
+
+        starting_panels = protocol_clients.length;
+    }
+
+    private void on_failsafe_timeout () {
+        if (starting_panels > 0) {
+            warning ("%d panels failed to start in time, showing the others", starting_panels);
+
+            starting_panels = 0;
+            foreach (var window in panel_windows.get_values ()) {
+                window.show ();
+            }
+        }
     }
 
     public void make_dock (Meta.Window window) {
@@ -160,10 +177,28 @@ public class Gala.ShellClientsManager : Object, GestureTarget {
 
         panel_windows[window] = new PanelWindow (wm, window, anchor);
 
+        InternalUtils.wait_for_window_actor_visible (window, on_panel_ready);
+
         // connect_after so we make sure the PanelWindow can destroy its barriers and struts
         window.unmanaging.connect_after ((_window) => panel_windows.remove (_window));
     }
 
+    private void on_panel_ready (Meta.WindowActor actor) {
+        if (starting_panels == 0) {
+            panel_windows[actor.meta_window].show ();
+            return;
+        }
+
+        starting_panels--;
+        assert (starting_panels >= 0);
+
+        if (starting_panels == 0) {
+            foreach (var window in panel_windows.get_values ()) {
+                window.show ();
+            }
+        }
+    }
+
     /**
      * The size given here is only used for the hide mode. I.e. struts
      * and collision detection with other windows use this size. By default

src/ShellClients/ShellWindow.vala

@@ -12,7 +12,14 @@ public abstract class Gala.ShellWindow : PositionedWindow, GestureTarget {
      * A gesture target that will receive a CUSTOM update every time a gesture
      * is propagated, with the progress gotten via {@link get_hidden_progress()}
      */
-    public GestureTarget hide_target { get; construct set; }
+    private GestureTarget? _hide_target = null;
+    public GestureTarget? hide_target {
+        private get { return _hide_target; }
+        construct set {
+            _hide_target = value;
+            _hide_target?.propagate (UPDATE, CUSTOM, get_hidden_progress ());
+        }
+    }
 
     private double multitasking_view_progress = 0;
     private int animations_ongoing = 0;
@@ -29,7 +36,7 @@ public abstract class Gala.ShellWindow : PositionedWindow, GestureTarget {
                     multitasking_view_progress = progress;
                 }
 
-                hide_target.propagate (UPDATE, CUSTOM, get_hidden_progress ());
+                hide_target?.propagate (UPDATE, CUSTOM, get_hidden_progress ());
                 break;
 
             case END: