Merge branch 'main' into leolost/gesture-action

Author: leolost2605

data/gala.metainfo.xml.in

@@ -27,7 +27,7 @@
   <update_contact>contact_at_elementary.io</update_contact>
 
   <releases>
-      <release version="8.0.5" date="2024-12-18" urgency="medium">
+      <release version="8.1.0" date="2025-01-11" urgency="medium">
       <description>
         <p>Improvements:</p>
         <ul>
@@ -39,14 +39,22 @@
       </description>
       <issues>
         <issue url="https://github.com/elementary/gala/issues/397">Prevent PIP overlapping wingpanel?</issue>
+        <issue url="https://github.com/elementary/gala/issues/551">Return to original workspace if a fullscreen window is closed and there is no more windows open</issue>
+        <issue url="https://github.com/elementary/gala/issues/815">Zoom with Super + Scroll</issue>
         <issue url="https://github.com/elementary/gala/issues/857">Toggling the active window's maximization state during multitasking view messes up the window preview size</issue>
+        <issue url="https://github.com/elementary/gala/issues/1178">Workspace Switching with Keyboard (meta) + Mouse scroll</issue>
         <issue url="https://github.com/elementary/gala/issues/1967">Some apps ignore HiDPI mode</issue>
+        <issue url="https://github.com/elementary/gala/issues/1986">Does not return to the first virtual desktop after exiting fullscreen mode.</issue>
         <issue url="https://github.com/elementary/gala/issues/2088">Invisible window clones</issue>
+        <issue url="https://github.com/elementary/gala/issues/2102">Notifications sometimes result in segfault</issue>
         <issue url="https://github.com/elementary/gala/issues/2113">gnome-session-x11-services-ready.target isn't started on Wayland session</issue>
         <issue url="https://github.com/elementary/gala/issues/2131">Unthemed cursor style and glitchy menus on some applications</issue>
+        <issue url="https://github.com/elementary/gala/issues/2154">Windows do not display correctly after moving between workspaces</issue>
         <issue url="https://github.com/elementary/gala/issues/2159">Crash when moving windows between workspaces and using gestures to switch</issue>
         <issue url="https://github.com/elementary/gala/issues/2169">Text UI based Scaling: Tiny Titlebars in XWayland Apps</issue>
+        <issue url="https://github.com/elementary/gala/issues/2170">Don’t show app icons in app window spread</issue>
         <issue url="https://github.com/elementary/gala/issues/2171">PiP dragging doesn't start until after mouse is released</issue>
+        <issue url="https://github.com/elementary/gala/issues/2175">Gala crashes when receiving a notification while switching workspaces</issue>
       </issues>
     </release>
 

meson.build

@@ -1,6 +1,6 @@
 project('gala',
     'c', 'vala',
-    version: '8.0.4',
+    version: '8.1.0',
     meson_version: '>= 0.59.0',
     license: 'GPL3',
 )

src/Gestures/GesturePropertyTransition.vala

@@ -84,7 +84,10 @@ public class Gala.GesturePropertyTransition : Object {
      * to the final position. If with_gesture is false it will just ease to the {@link to_value}.
      * #this will keep itself alive until the animation finishes so it is safe to immediatly unref it after creation and calling start.
      *
-     * @param done_callback a callback for when the transition finishes. It is guaranteed to be called exactly once.
+     * @param done_callback a callback for when the transition finishes. This shouldn't be used for setting state, instead state should
+     * be set immediately on {@link GestureTracker.OnEnd} not only once the animation ends to allow for interrupting the animation by starting a new gesture.
+     * done_callback will only be called if the animation finishes, not if it is interrupted e.g. by starting a new animation for the same property,
+     * destroying the actor or removing the transition.
      */
     public void start (bool with_gesture, owned DoneCallback? done_callback = null) {
         ref ();
@@ -179,8 +182,8 @@ public class Gala.GesturePropertyTransition : Object {
         }
     }
 
-    private void finish () {
-        if (done_callback != null) {
+    private void finish (bool callback = true) {
+        if (done_callback != null && callback) {
             done_callback ();
         }
 

src/HotCorners/HotCornerManager.vala

@@ -92,20 +92,16 @@ public class Gala.HotCornerManager : Object {
     private void run_custom_action (string hot_corner_position) {
         string command = "";
         var line = behavior_settings.get_string ("hotcorner-custom-command");
-        if (line == "")
+        if (line == "") {
             return;
+        }
 
         var parts = line.split (";;");
-        // keep compatibility to old version where only one command was possible
-        if (parts.length == 1) {
-            command = line;
-        } else {
-            // find specific actions
-            foreach (unowned var part in parts) {
-                var details = part.split (":");
-                if (details[0] == hot_corner_position) {
-                    command = details[1];
-                }
+        // find specific actions
+        foreach (unowned var part in parts) {
+            var details = part.split (":", 2);
+            if (details[0] == hot_corner_position) {
+                command = details[1];
             }
         }
 

src/InternalUtils.vala

@@ -369,5 +369,16 @@ namespace Gala {
                 }
             });
         }
+
+        public static void clutter_actor_reparent (Clutter.Actor actor, Clutter.Actor new_parent) {
+            if (actor == new_parent) {
+                return;
+            }
+
+            actor.ref ();
+            actor.get_parent ().remove_child (actor);
+            new_parent.add_child (actor);
+            actor.unref ();
+        }
     }
 }

src/ScreenshotManager.vala

@@ -155,7 +155,7 @@ namespace Gala {
             var rect = window.get_frame_rect ();
 #if HAS_MUTTER45
             if (!include_frame) {
-#if else
+#else
             if ((include_frame && window.is_client_decorated ()) ||
                 (!include_frame && !window.is_client_decorated ())) {
 #endif

src/ShellClients/PanelWindow.vala

@@ -36,16 +36,16 @@ public class Gala.PanelWindow : Object {
 
         unowned var display = wm.get_display ();
 
+        window_positioner = new WindowPositioner (display, window, WindowPositioner.Position.from_anchor (anchor));
+
+        notify["anchor"].connect (() => window_positioner.position = WindowPositioner.Position.from_anchor (anchor));
+
         unowned var workspace_manager = display.get_workspace_manager ();
         workspace_manager.workspace_added.connect (update_strut);
         workspace_manager.workspace_removed.connect (update_strut);
 
         window.size_changed.connect (update_strut);
         window.position_changed.connect (update_strut);
-
-        window_positioner = new WindowPositioner (display, window, WindowPositioner.Position.from_anchor (anchor));
-
-        notify["anchor"].connect (() => window_positioner.position = WindowPositioner.Position.from_anchor (anchor));
     }
 
 #if HAS_MUTTER45

src/Widgets/WindowClone.vala

@@ -266,6 +266,10 @@ public class Gala.WindowClone : Clutter.Actor {
             update_hover_widgets (false);
             toggle_shadow (false);
         });
+
+        if (should_fade ()) {
+            new GesturePropertyTransition (this, gesture_tracker, "opacity", null, 0u).start (with_gesture);
+        }
     }
 
     /**
@@ -294,6 +298,7 @@ public class Gala.WindowClone : Clutter.Actor {
         new GesturePropertyTransition (this, gesture_tracker, "y", intial_y, (float) rect.y).start (with_gesture);
         new GesturePropertyTransition (this, gesture_tracker, "width", (float) initial_width, (float) rect.width).start (with_gesture);
         new GesturePropertyTransition (this, gesture_tracker, "height", (float) initial_height, (float) rect.height).start (with_gesture);
+        new GesturePropertyTransition (this, gesture_tracker, "opacity", null, 255u).start (with_gesture);
         new GesturePropertyTransition (this, gesture_tracker, "shadow-opacity", (uint8) 0, (uint8) 255).start (with_gesture);
         new GesturePropertyTransition (window_icon, gesture_tracker, "opacity", 0u, 255u).start (with_gesture, () => {
             update_hover_widgets (false);