Skip to content

Commit 3363522

Browse files
lenemtertintou
authored andcommitted
Replace libcanberra with Meta.SoundPlayer
1 parent e3e1ede commit 3363522

File tree

5 files changed

+5
-18
lines changed

5 files changed

+5
-18
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Install Dependencies
3232
run: |
3333
apt update
34-
apt install -y gettext gsettings-desktop-schemas-dev libatk-bridge2.0-dev libcanberra-dev libclutter-1.0-dev libgee-0.8-dev libglib2.0-dev libgnome-desktop-3-dev libgranite-dev libgtk-3-dev ${{ matrix.mutter_pkg }} libsqlite3-dev meson valac valadoc
34+
apt install -y gettext gsettings-desktop-schemas-dev libatk-bridge2.0-dev libclutter-1.0-dev libgee-0.8-dev libglib2.0-dev libgnome-desktop-3-dev libgranite-dev libgtk-3-dev ${{ matrix.mutter_pkg }} libsqlite3-dev meson valac valadoc
3535
- name: Build
3636
env:
3737
DESTDIR: out
@@ -50,7 +50,7 @@ jobs:
5050
- uses: actions/checkout@v5
5151
- name: Install Dependencies
5252
run: |
53-
dnf install -y desktop-file-utils gettext gsettings-desktop-schemas-devel atk-devel libcanberra-devel clutter-devel libgee-devel glib2-devel gnome-desktop3-devel granite-devel granite-7-devel gtk3-devel gtk4-devel libhandy-devel mutter-devel sqlite-devel meson valac valadoc
53+
dnf install -y desktop-file-utils gettext gsettings-desktop-schemas-devel atk-devel clutter-devel libgee-devel glib2-devel gnome-desktop3-devel granite-devel granite-7-devel gtk3-devel gtk4-devel libhandy-devel mutter-devel sqlite-devel meson valac valadoc
5454
- name: Build
5555
env:
5656
DESTDIR: out
@@ -69,7 +69,7 @@ jobs:
6969
run: |
7070
zypper addrepo https://download.opensuse.org/repositories/X11:Pantheon/15.6/X11:Pantheon.repo
7171
zypper --gpg-auto-import-keys refresh
72-
zypper --non-interactive install tar git desktop-file-utils gsettings-desktop-schemas-devel libatk-1_0-0 libcanberra-devel clutter-devel libgee-devel glib2-devel libgnome-desktop-3-devel granite6-devel granite-devel gtk3-devel gtk4-devel libhandy-devel mutter-devel sqlite3-devel meson vala valadoc gcc
72+
zypper --non-interactive install tar git desktop-file-utils gsettings-desktop-schemas-devel libatk-1_0-0 clutter-devel libgee-devel glib2-devel libgnome-desktop-3-devel granite6-devel granite-devel gtk3-devel gtk4-devel libhandy-devel mutter-devel sqlite3-devel meson vala valadoc gcc
7373
- uses: actions/checkout@v5
7474
- name: Build
7575
env:

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ A window & compositing manager based on libmutter and designed by elementary for
88
You'll need the following dependencies:
99
* gettext (>= 0.19.6)
1010
* gsettings-desktop-schemas-dev
11-
* libcanberra-dev
1211
* libclutter-1.0-dev (>= 1.12.0)
1312
* libgee-0.8-dev
1413
* libglib2.0-dev (>= 2.74)

docs/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ basic_command = [
2020
'--pkg', 'gio-unix-2.0',
2121
'--pkg', 'gmodule-2.0',
2222
'--pkg', 'posix',
23-
'--pkg', 'libcanberra',
2423
'--pkg', 'sqlite3',
2524
'--pkg', 'libsystemd',
2625
'--pkg', 'granite',

meson.build

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ glib_version_required = '2.74.0'
7373
gtk_version_required = '3.10.0'
7474

7575
atk_bridge_dep = dependency('atk-bridge-2.0')
76-
canberra_dep = dependency('libcanberra')
7776
glib_dep = dependency('glib-2.0', version: '>= @0@'.format(glib_version_required))
7877
gobject_dep = dependency('gobject-2.0', version: '>= @0@'.format(glib_version_required))
7978
gio_dep = dependency('gio-2.0', version: '>= @0@'.format(glib_version_required))
@@ -169,7 +168,7 @@ endif
169168
add_project_arguments(vala_flags, language: 'vala')
170169
add_project_link_arguments(['-Wl,-rpath,@0@'.format(mutter_typelib_dir)], language: 'c')
171170

172-
gala_base_dep = [atk_bridge_dep, canberra_dep, glib_dep, gobject_dep, gio_dep, gio_unix_dep, gmodule_dep, gee_dep, gtk_dep, mutter_dep, gnome_desktop_dep, m_dep, posix_dep, sqlite3_dep, xext_dep, config_dep]
171+
gala_base_dep = [atk_bridge_dep, glib_dep, gobject_dep, gio_dep, gio_unix_dep, gmodule_dep, gee_dep, gtk_dep, mutter_dep, gnome_desktop_dep, m_dep, posix_dep, sqlite3_dep, xext_dep, config_dep]
173172

174173
if get_option('systemd')
175174
gala_base_dep += systemd_dep

src/ScreenshotManager.vala

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -552,17 +552,7 @@ public class Gala.ScreenshotManager : Object {
552552
}
553553

554554
private void play_shutter_sound () {
555-
Canberra.Context context;
556-
Canberra.Proplist props;
557-
558-
Canberra.Context.create (out context);
559-
Canberra.Proplist.create (out props);
560-
561-
props.sets (Canberra.PROP_EVENT_ID, "screen-capture");
562-
props.sets (Canberra.PROP_EVENT_DESCRIPTION, _("Screenshot taken"));
563-
props.sets (Canberra.PROP_CANBERRA_CACHE_CONTROL, "permanent");
564-
565-
context.play_full (0, props, null);
555+
wm.get_display ().get_sound_player ().play_from_theme ("screen-capture", _("Screenshot taken"));
566556
}
567557

568558
private Cairo.ImageSurface take_screenshot (int x, int y, int width, int height, bool include_cursor) {

0 commit comments

Comments
 (0)