Skip to content

Commit 38577d7

Browse files
committed
Avoid making DBusAccelerator static
1 parent ece7592 commit 38577d7

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

src/DBus.vala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class Gala.DBus {
1111
private static WindowManagerGala wm;
1212

1313
[DBus (visible = false)]
14-
public static void init (WindowManagerGala _wm, ScreenshotManager screenshot_manager) {
14+
public static void init (WindowManagerGala _wm, DBusAccelerator dbus_accelerator, ScreenshotManager screenshot_manager) {
1515
wm = _wm;
1616

1717
Bus.own_name (BusType.SESSION, "org.pantheon.gala", BusNameOwnerFlags.NONE,
@@ -33,7 +33,7 @@ public class Gala.DBus {
3333
Bus.own_name (BusType.SESSION, "org.gnome.Shell", BusNameOwnerFlags.NONE,
3434
(connection) => {
3535
try {
36-
connection.register_object ("/org/gnome/Shell", DBusAccelerator.init (wm.get_display ()));
36+
connection.register_object ("/org/gnome/Shell", dbus_accelerator);
3737
connection.register_object ("/org/gnome/Shell/Screenshot", screenshot_manager);
3838
} catch (Error e) { warning (e.message); }
3939
},

src/DBusAccelerator.vala

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,23 +72,12 @@ namespace Gala {
7272

7373
[DBus (name="org.gnome.Shell")]
7474
public class DBusAccelerator {
75-
private static DBusAccelerator? instance;
76-
77-
[DBus (visible = false)]
78-
public static unowned DBusAccelerator init (Meta.Display display) {
79-
if (instance == null) {
80-
instance = new DBusAccelerator (display);
81-
}
82-
83-
return instance;
84-
}
85-
8675
public signal void accelerator_activated (uint action, GLib.HashTable<string, Variant> parameters);
8776

8877
private Meta.Display display;
8978
private GLib.HashTable<unowned string, GrabbedAccelerator> grabbed_accelerators;
9079

91-
private DBusAccelerator (Meta.Display _display) {
80+
public DBusAccelerator (Meta.Display _display) {
9281
display = _display;
9382
grabbed_accelerators = new HashTable<unowned string, GrabbedAccelerator> (str_hash, str_equal);
9483
display.accelerator_activated.connect (on_accelerator_activated);

src/WindowManager.vala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ namespace Gala {
7171

7272
public WindowTracker? window_tracker { get; private set; }
7373

74+
private DBusAccelerator dbus_accelerator;
75+
7476
private ScreenshotManager screenshot_manager;
7577

7678
/**
@@ -190,8 +192,8 @@ namespace Gala {
190192
unowned Meta.Display display = get_display ();
191193

192194
screenshot_manager = new ScreenshotManager (this);
193-
DBus.init (this, screenshot_manager);
194-
DBusAccelerator.init (display);
195+
dbus_accelerator = new DBusAccelerator (display);
196+
DBus.init (this, dbus_accelerator, screenshot_manager);
195197
MediaFeedback.init ();
196198

197199
WindowListener.init (display);

0 commit comments

Comments
 (0)