Beep when activate_workspace does nothing

lenemter · lenemter · commit 84963fd719ca · 2025-02-14T11:00:06.000+03:00
diff --git a/src/DesktopIntegration.vala b/src/DesktopIntegration.vala
@@ -139,7 +139,13 @@ public class Gala.DesktopIntegration : GLib.Object {
             throw new IOError.NOT_FOUND ("Workspace not found");
         }
 
-        workspace.activate (wm.get_display ().get_current_time ());
+        unowned var display = wm.get_display ();
+        unowned var active_workspace_index = display.get_workspace_manager ().get_active_workspace_index ();
+        if (active_workspace_index == index) {
+            InternalUtils.bell_notify (display);
+        } else {
+            workspace.activate (display.get_current_time ());
+        }
     }
 
     public int get_n_workspaces () throws GLib.DBusError, GLib.IOError {

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,13 @@ public class Gala.DesktopIntegration : GLib.Object {`
`139`	`139`	`throw new IOError.NOT_FOUND ("Workspace not found");`
`140`	`140`	`}`
`141`	`141`
`142`		`- workspace.activate (wm.get_display ().get_current_time ());`
	`142`	`+ unowned var display = wm.get_display ();`
	`143`	`+ unowned var active_workspace_index = display.get_workspace_manager ().get_active_workspace_index ();`
	`144`	`+ if (active_workspace_index == index) {`
	`145`	`+ InternalUtils.bell_notify (display);`
	`146`	`+ } else {`
	`147`	`+ workspace.activate (display.get_current_time ());`
	`148`	`+ }`
`143`	`149`	`}`
`144`	`150`
`145`	`151`	`public int get_n_workspaces () throws GLib.DBusError, GLib.IOError {`