Rely less on ShellClientsManager

Author: lenemter

src/DesktopIntegration.vala

@@ -78,10 +78,6 @@ public class Gala.DesktopIntegration : GLib.Object {
             return false;
         }
 
-        if (ShellClientsManager.get_instance ().is_positioned_window (window)) {
-            return false;
-        }
-
         switch (window.get_window_type ()) {
             case Meta.WindowType.NORMAL:
             case Meta.WindowType.DIALOG:

src/InternalUtils.vala

@@ -210,17 +210,19 @@ namespace Gala {
             });
 
             foreach (var window in list) {
-                if (!ShellClientsManager.get_instance ().is_positioned_window (window)) {
-                    if (any_window == null) {
-                        any_window = window;
-                    }
+                if (window.find_root_ancestor ().window_type == DOCK) {
+                    continue;
+                }
 
-                    if (!Utils.get_window_is_normal (window)) {
-                        continue;
-                    }
+                if (any_window == null) {
+                    any_window = window;
+                }
 
-                    return window;
+                if (!Utils.get_window_is_normal (window)) {
+                    continue;
                 }
+
+                return window;
             }
 
             return null;

src/ShellClients/ShellWindow.vala

@@ -76,16 +76,11 @@ public abstract class Gala.ShellWindow : PositionedWindow, GestureTarget {
             }
         }
 
-        unowned var manager = ShellClientsManager.get_instance ();
         window.foreach_transient ((transient) => {
-            if (manager.is_itself_positioned (transient)) {
-                return true;
+            if (!Utils.get_window_is_normal (window)) {
+                ((Meta.WindowActor) transient.get_compositor_private ()).visible = visible && !animating;
             }
 
-            unowned var transient_window_actor = (Meta.WindowActor) transient.get_compositor_private ();
-
-            transient_window_actor.visible = visible && !animating;
-
             return true;
         });
     }

src/WindowStateSaver.vala

@@ -79,7 +79,6 @@ public class Gala.WindowStateSaver : GLib.Object {
         var app_id = window_tracker.get_app_for_window (window).id;
 
         if (app_id.has_prefix ("window:") || // if window failed to be identified, don't remember it
-            ShellClientsManager.get_instance ().is_positioned_window (window) ||
             window.window_type != Meta.WindowType.NORMAL ||
             window.skip_taskbar ||
             !window.resizeable ||