Add with_gesture for now

Author: leolost2605

src/Gestures/GestureTracker.vala

@@ -196,10 +196,10 @@ public class Gala.GestureTracker : Object {
     }
 
     /**
-     * Connects a callback that will only be called if != 0 completions were made.
+     * Connects a callback that will be called as soon as the gesture finishes.
      * If with_gesture is false it will be called immediately, otherwise once {@link on_end} is emitted.
      */
-    public void add_success_callback (bool with_gesture, owned OnEnd callback) {
+    public void add_end_callback (bool with_gesture, owned OnEnd callback) {
         if (!with_gesture) {
             callback (1, 1, min_animation_duration);
         } else {

src/ShellClients/PanelWindow.vala

@@ -113,15 +113,15 @@ public class Gala.PanelWindow : ShellWindow {
     }
 
     private void hide () {
-        add_state (CUSTOM_HIDDEN, default_gesture_tracker);
+        add_state (CUSTOM_HIDDEN, default_gesture_tracker, false);
     }
 
     private void show () {
         if (window.display.get_monitor_in_fullscreen (window.get_monitor ())) {
             return;
         }
 
-        remove_state (CUSTOM_HIDDEN, default_gesture_tracker);
+        remove_state (CUSTOM_HIDDEN, default_gesture_tracker, false);
     }
 
     private void make_exclusive () {

src/ShellClients/ShellClientsManager.vala

@@ -190,23 +190,23 @@ public class Gala.ShellClientsManager : Object {
         window.unmanaging.connect_after ((_window) => positioned_windows.remove (_window));
     }
 
-    public void add_state (ShellWindow.State state, GestureTracker gesture_tracker) {
+    public void add_state (ShellWindow.State state, GestureTracker gesture_tracker, bool with_gesture) {
         foreach (var window in positioned_windows.get_values ()) {
-            window.add_state (state, gesture_tracker);
+            window.add_state (state, gesture_tracker, with_gesture);
         }
 
         foreach (var window in panel_windows.get_values ()) {
-            window.add_state (state, gesture_tracker);
+            window.add_state (state, gesture_tracker, with_gesture);
         }
     }
 
-    public void remove_state (ShellWindow.State state, GestureTracker gesture_tracker) {
+    public void remove_state (ShellWindow.State state, GestureTracker gesture_tracker, bool with_gesture) {
         foreach (var window in positioned_windows.get_values ()) {
-            window.remove_state (state, gesture_tracker);
+            window.remove_state (state, gesture_tracker, with_gesture);
         }
 
         foreach (var window in panel_windows.get_values ()) {
-            window.remove_state (state, gesture_tracker);
+            window.remove_state (state, gesture_tracker, with_gesture);
         }
     }
 

src/ShellClients/ShellWindow.vala

@@ -28,15 +28,15 @@ public class Gala.ShellWindow : PositionedWindow {
         actor = (Meta.WindowActor) window.get_compositor_private ();
     }
 
-    public void add_state (State state, GestureTracker gesture_tracker) {
-        animate (current_state | state, gesture_tracker);
+    public void add_state (State state, GestureTracker gesture_tracker, bool with_gesture) {
+        animate (current_state | state, gesture_tracker, with_gesture);
     }
 
-    public void remove_state (State state, GestureTracker gesture_tracker) {
-        animate (current_state & ~state, gesture_tracker);
+    public void remove_state (State state, GestureTracker gesture_tracker, bool with_gesture) {
+        animate (current_state & ~state, gesture_tracker, with_gesture);
     }
 
-    private void animate (State new_state, GestureTracker gesture_tracker) {
+    private void animate (State new_state, GestureTracker gesture_tracker, bool with_gesture) {
         if (new_state == current_state || gesture_ongoing) {
             return;
         }
@@ -51,9 +51,9 @@ public class Gala.ShellWindow : PositionedWindow {
 
         new GesturePropertyTransition (
             actor, gesture_tracker, get_animation_property (), null, calculate_value ((new_state & HIDING_STATES) != 0)
-        ).start (true, () => InternalUtils.update_transients_visible (window, (current_state & HIDING_STATES) == 0));
+        ).start (with_gesture, () => InternalUtils.update_transients_visible (window, (current_state & HIDING_STATES) == 0));
 
-        gesture_tracker.add_success_callback (false, (percentage, completions) => {
+        gesture_tracker.add_end_callback (with_gesture, (percentage, completions) => {
             if (completions != 0) {
                 current_state = new_state;
             }

src/Widgets/MultitaskingView.vala

@@ -671,9 +671,9 @@ namespace Gala {
             }
 
             if (opening) {
-                ShellClientsManager.get_instance ().add_state (MULTITASKING_VIEW, multitasking_gesture_tracker);
+                ShellClientsManager.get_instance ().add_state (MULTITASKING_VIEW, multitasking_gesture_tracker, with_gesture);
             } else {
-                ShellClientsManager.get_instance ().remove_state (MULTITASKING_VIEW, multitasking_gesture_tracker);
+                ShellClientsManager.get_instance ().remove_state (MULTITASKING_VIEW, multitasking_gesture_tracker, with_gesture);
             }
 
             GestureTracker.OnEnd on_animation_end = (percentage, completions) => {