Merge branch 'main' into leolost/window-clone-allocate-warnings

Author: lenemter

data/gala.metainfo.xml.in

@@ -27,7 +27,7 @@
   <update_contact>contact_at_elementary.io</update_contact>
 
   <releases>
-    <release version="8.3.0" date="2025-10-28" urgency="medium">
+    <release version="8.3.0" date="2025-11-05" urgency="medium">
       <description>
         <p>Improvements:</p>
           <ul>
@@ -40,10 +40,12 @@
         </ul>
       </description>
       <issues>
+        <issue url="https://github.com/elementary/gala/issues/335">Close button isn't always on top</issue>
         <issue url="https://github.com/elementary/gala/issues/501">Tiled and maximized widows show different behaviour on wingpanel when in front of fullscreen windows</issue>
         <issue url="https://github.com/elementary/gala/issues/1385">Urgent notifications can get offset</issue>
         <issue url="https://github.com/elementary/gala/issues/1998">Blur Behind</issue>
         <issue url="https://github.com/elementary/gala/issues/2057">Trying to change desktop bg to a color don´t work</issue>
+        <issue url="https://github.com/elementary/gala/issues/2071">Dock overlapping right-click menu on elementary OS 8</issue>
         <issue url="https://github.com/elementary/gala/issues/2079">Gala app icon shows up in Dock briefly</issue>
         <issue url="https://github.com/elementary/gala/issues/2333">Wingpanel crashes than reappears in the middle of the screen</issue>
         <issue url="https://github.com/elementary/gala/issues/2399">Horizontal swipe to switch workspace no longer follows natural scrolling setting</issue>
@@ -55,7 +57,7 @@
         <issue url="https://github.com/elementary/gala/issues/2507">Logs filled with assertion fails / failure messages</issue>
         <issue url="https://github.com/elementary/gala/issues/2515">Main window is being resized to dialog/child window size after reopen</issue>
         <issue url="https://github.com/elementary/gala/issues/2530">Freezing minimized windows</issue>
-        <issue url="https://github.com/elementary/dock/discussions/478">Dock is shown over fullscreen apps</issue>
+        <issue url="https://github.com/elementary/dock/issues/479">Dock is shown over fullscreen apps</issue>
         <issue url="https://github.com/elementary/wingpanel/issues/639">Wingpanel starts at middle of the screen</issue>
       </issues>
     </release>

lib/CloseButton.vala

@@ -8,20 +8,21 @@ public class Gala.CloseButton : Clutter.Actor {
     private static Gee.HashMap<int, Gdk.Pixbuf?> close_pixbufs;
 
     public signal void triggered (uint32 timestamp);
-    public float scale { get; construct set; }
+
+    public float monitor_scale { get; construct set; }
 
     // used to avoid changing hitbox of the button
     private Clutter.Actor pixbuf_actor;
     private bool is_pressed = false;
 
-    public CloseButton (float scale) {
-        Object (scale: scale);
-    }
-
     static construct {
         close_pixbufs = new Gee.HashMap<int, Gdk.Pixbuf?> ();
     }
 
+    public CloseButton (float monitor_scale) {
+        Object (monitor_scale: monitor_scale);
+    }
+
     construct {
         reactive = true;
 
@@ -30,23 +31,24 @@ public class Gala.CloseButton : Clutter.Actor {
         };
         add_child (pixbuf_actor);
 
-        var pixbuf = get_close_button_pixbuf (scale);
+        load_pixbuf ();
+        notify["monitor-scale"].connect (load_pixbuf);
+    }
+
+    private void load_pixbuf () {
+        var pixbuf = get_close_button_pixbuf (monitor_scale);
         if (pixbuf != null) {
-            try {
-                var image = new Gala.Image.from_pixbuf (pixbuf);
-                pixbuf_actor.set_content (image);
-                pixbuf_actor.set_size (pixbuf.width, pixbuf.height);
-                set_size (pixbuf.width, pixbuf.height);
-            } catch (Error e) {
-                create_error_texture ();
-            }
+            var image = new Gala.Image.from_pixbuf (pixbuf);
+            pixbuf_actor.set_content (image);
+            pixbuf_actor.set_size (pixbuf.width, pixbuf.height);
+            set_size (pixbuf.width, pixbuf.height);
         } else {
             create_error_texture ();
         }
     }
 
-    private static Gdk.Pixbuf? get_close_button_pixbuf (float scale) {
-        var height = Utils.calculate_button_size (scale);
+    private static Gdk.Pixbuf? get_close_button_pixbuf (float monitor_scale) {
+        var height = Utils.calculate_button_size (monitor_scale);
 
         if (close_pixbufs[height] == null) {
             try {
@@ -71,7 +73,7 @@ public class Gala.CloseButton : Clutter.Actor {
         // works as good as some weird fallback-image-failed-to-load pixbuf
         critical ("Could not create close button");
 
-        var size = Utils.calculate_button_size (scale);
+        var size = Utils.calculate_button_size (monitor_scale);
         pixbuf_actor.set_size (size, size);
         pixbuf_actor.background_color = { 255, 0, 0, 255 };
     }

lib/Drawing/StyleManager.vala

@@ -33,7 +33,7 @@ public class Gala.Drawing.StyleManager : Object {
     private const uint8 ACCENT_COLOR_ALPHA = 64;
 
     private static GLib.Once<StyleManager> instance;
-    public static StyleManager get_instance () {
+    public static unowned StyleManager get_instance () {
         return instance.once (() => new StyleManager ());
     }
 

lib/Gestures/GestureController.vala

@@ -64,7 +64,6 @@ public class Gala.GestureController : Object {
 
     /**
      * When disabled gesture progress will stay where the gesture ended and not snap to full integers values.
-     * This will also cause the controller to emit smooth progress information even if animations are disabled.
      */
     public bool snap { get; construct set; default = true; }
 
@@ -173,12 +172,6 @@ public class Gala.GestureController : Object {
                 direction_multiplier *= -1;
             }
 
-            if (snap && !Meta.Prefs.get_gnome_animations ()) {
-                recognizing = false;
-                prepare ();
-                finish (0, progress + direction_multiplier);
-            }
-
             recognizing_backend = backend;
         }
 

meson.build

@@ -1,6 +1,6 @@
 project('gala',
     'vala',
-    version: '8.2.5',
+    version: '8.3.0',
     meson_version: '>= 0.59.0',
     license: 'GPL3',
 )

po/aa.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: gala 3.2.0\n"
 "Report-Msgid-Bugs-To: https://github.com/elementary/gala/issues\n"
-"POT-Creation-Date: 2025-10-28 21:49+0000\n"
+"POT-Creation-Date: 2025-11-05 20:49+0000\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: Automatically generated\n"
 "Language-Team: none\n"
@@ -102,25 +102,25 @@ msgstr ""
 msgid "elementary, Inc."
 msgstr ""
 
-#: data/gala.metainfo.xml.in:32 data/gala.metainfo.xml.in:65
-#: data/gala.metainfo.xml.in:77 data/gala.metainfo.xml.in:92
-#: data/gala.metainfo.xml.in:118 data/gala.metainfo.xml.in:130
-#: data/gala.metainfo.xml.in:144 data/gala.metainfo.xml.in:177
-#: data/gala.metainfo.xml.in:208 data/gala.metainfo.xml.in:221
-#: data/gala.metainfo.xml.in:236 data/gala.metainfo.xml.in:253
-#: data/gala.metainfo.xml.in:269 data/gala.metainfo.xml.in:310
-#: data/gala.metainfo.xml.in:335 data/gala.metainfo.xml.in:351
-msgid "Improvements:"
-msgstr ""
-
-#: data/gala.metainfo.xml.in:34 data/gala.metainfo.xml.in:67
+#: data/gala.metainfo.xml.in:32 data/gala.metainfo.xml.in:67
 #: data/gala.metainfo.xml.in:79 data/gala.metainfo.xml.in:94
 #: data/gala.metainfo.xml.in:120 data/gala.metainfo.xml.in:132
 #: data/gala.metainfo.xml.in:146 data/gala.metainfo.xml.in:179
 #: data/gala.metainfo.xml.in:210 data/gala.metainfo.xml.in:223
-#: data/gala.metainfo.xml.in:238 data/gala.metainfo.xml.in:257
-#: data/gala.metainfo.xml.in:273 data/gala.metainfo.xml.in:316
-#: data/gala.metainfo.xml.in:338 data/gala.metainfo.xml.in:353
+#: data/gala.metainfo.xml.in:238 data/gala.metainfo.xml.in:255
+#: data/gala.metainfo.xml.in:271 data/gala.metainfo.xml.in:312
+#: data/gala.metainfo.xml.in:337 data/gala.metainfo.xml.in:353
+msgid "Improvements:"
+msgstr ""
+
+#: data/gala.metainfo.xml.in:34 data/gala.metainfo.xml.in:69
+#: data/gala.metainfo.xml.in:81 data/gala.metainfo.xml.in:96
+#: data/gala.metainfo.xml.in:122 data/gala.metainfo.xml.in:134
+#: data/gala.metainfo.xml.in:148 data/gala.metainfo.xml.in:181
+#: data/gala.metainfo.xml.in:212 data/gala.metainfo.xml.in:225
+#: data/gala.metainfo.xml.in:240 data/gala.metainfo.xml.in:259
+#: data/gala.metainfo.xml.in:275 data/gala.metainfo.xml.in:318
+#: data/gala.metainfo.xml.in:340 data/gala.metainfo.xml.in:355
 msgid "Updated translations"
 msgstr ""
 
@@ -144,69 +144,69 @@ msgstr ""
 msgid "Picture-in-Picture windows now have rounded corners"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:147
+#: data/gala.metainfo.xml.in:149
 msgid "Window state is now saved on sleep and shutdown"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:148
+#: data/gala.metainfo.xml.in:150
 msgid "Remove scaling effect from menus"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:149
+#: data/gala.metainfo.xml.in:151
 msgid "Swipe up to close windows in Multitasking View"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:180
+#: data/gala.metainfo.xml.in:182
 msgid "Fixed rare crash when a dock window was killed"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:181
+#: data/gala.metainfo.xml.in:183
 msgid "Added interactive screenshot shortcut"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:182
+#: data/gala.metainfo.xml.in:184
 msgid "Fixed crash when using tiling shortcuts"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:211
+#: data/gala.metainfo.xml.in:213
 msgid "Improved shadows performance"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:255
+#: data/gala.metainfo.xml.in:257
 msgid "Fix a potential crash when moving windows between workspaces"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:256
+#: data/gala.metainfo.xml.in:258
 msgid "Fix notification animation when entering multitasking view"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:271
+#: data/gala.metainfo.xml.in:273
 msgid "Improve keyboard navigation in Multitasking View"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:272
+#: data/gala.metainfo.xml.in:274
 msgid "Change panel color at the same time as wallpaper transition"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:312
+#: data/gala.metainfo.xml.in:314
 msgid ""
 "Changing the wallpaper or going to sleep respects the \"Reduce Motion\" "
 "option"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:313
+#: data/gala.metainfo.xml.in:315
 msgid "Use appropriate drag-and-drop pointers when moving windows"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:314
+#: data/gala.metainfo.xml.in:316
 msgid "Fix the issue when gestures in the multitasking view might stop working"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:315
+#: data/gala.metainfo.xml.in:317
 msgid "Improve dynamic workspaces behaviour with multiple monitors"
 msgstr ""
 
-#: data/gala.metainfo.xml.in:337
+#: data/gala.metainfo.xml.in:339
 msgid "Improve handling of move-to-workspace shortcut"
 msgstr ""
 
@@ -308,25 +308,25 @@ msgstr ""
 msgid "Screenshots"
 msgstr ""
 
-#: src/Widgets/WindowSwitcher/WindowSwitcher.vala:80
+#: src/Widgets/WindowSwitcher/WindowSwitcher.vala:78
 msgid "Window switcher"
 msgstr ""
 
-#: src/WindowManager.vala:1719
+#: src/WindowManager.vala:1739
 #, c-format
 msgid "Changes will automatically revert after %i second."
 msgid_plural "Changes will automatically revert after %i seconds."
 msgstr[0] ""
 msgstr[1] ""
 
-#: src/WindowManager.vala:1726
+#: src/WindowManager.vala:1746
 msgid "Keep new display settings?"
 msgstr ""
 
-#: src/WindowManager.vala:1730
+#: src/WindowManager.vala:1750
 msgid "Keep Settings"
 msgstr ""
 
-#: src/WindowManager.vala:1731
+#: src/WindowManager.vala:1751
 msgid "Use Previous Settings"
 msgstr ""