WindowOverview: Dim background, keep other windows visible

Author: leolost2605

src/DesktopIntegration.vala

@@ -233,8 +233,12 @@ public class Gala.DesktopIntegration : GLib.Object {
             throw new IOError.NOT_FOUND ("App not found");
         }
 
+        var sorted_windows = wm.get_display ().sort_windows_by_stacking (app.get_windows ());
+
         uint64[] window_ids = {};
-        foreach (var window in app.get_windows ()) {
+        foreach (var window in sorted_windows) {
+            window.raise_and_make_recent_on_workspace (window.get_workspace ());
+            window.focus (Meta.CURRENT_TIME);
             window_ids += window.get_id ();
         }
 

src/Widgets/WindowOverview.vala

@@ -14,6 +14,7 @@ public class Gala.WindowOverview : ActorTarget, ActivatableComponent {
 
     private GestureController gesture_controller; // Currently not used for actual touchpad gestures but only as controller
 
+    private Clutter.Actor background;
     private Clutter.Actor monitors;
     private ModalProxy modal_proxy;
 
@@ -28,6 +29,18 @@ public class Gala.WindowOverview : ActorTarget, ActivatableComponent {
             enabled = false
         };
 
+        background = new Clutter.Actor () {
+#if HAS_MUTTER47
+            background_color = Cogl.Color.from_string ("black")
+#else
+            background_color = Clutter.Color.from_string ("black")
+#endif
+        };
+        background.add_constraint (new Clutter.BindConstraint (this, SIZE, 0));
+        add_child (background);
+
+        add_target (new PropertyTarget (MULTITASKING_VIEW, background, "opacity", typeof (uint), 0u, 150u));
+
         monitors = new ActorTarget ();
         add_child (monitors);
     }
@@ -72,17 +85,11 @@ public class Gala.WindowOverview : ActorTarget, ActivatableComponent {
         var windows = new List<Meta.Window> ();
         foreach (unowned var window_actor in wm.get_display ().get_window_actors ()) {
             var window = window_actor.meta_window;
-            if (ShellClientsManager.get_instance ().is_positioned_window (window)) {
-                continue;
-            }
-
-            if (window.window_type != Meta.WindowType.NORMAL &&
-                window.window_type != Meta.WindowType.DIALOG ||
+            if (ShellClientsManager.get_instance ().is_positioned_window (window) ||
+                window.window_type != NORMAL && window.window_type != DIALOG ||
                 window.is_attached_dialog () ||
                 window_ids != null && !(window.get_id () in window_ids)
             ) {
-                window_actor.hide ();
-
                 continue;
             }
 

src/WindowManager.vala

@@ -254,17 +254,17 @@ namespace Gala {
                 Meta.KeyBinding.set_custom_handler ("switch-group-backward", (Meta.KeyHandlerFunc) window_switcher.handle_switch_windows);
             }
 
+            // Add the remaining components that should be on top
+            shell_group = new Clutter.Actor ();
+            ui_group.add_child (shell_group);
+
             if (plugin_manager.window_overview_provider == null
                 || (window_overview = (plugin_manager.get_plugin (plugin_manager.window_overview_provider) as ActivatableComponent)) == null
             ) {
                 window_overview = new WindowOverview (this);
                 ui_group.add_child ((Clutter.Actor) window_overview);
             }
 
-            // Add the remaining components that should be on top
-            shell_group = new Clutter.Actor ();
-            ui_group.add_child (shell_group);
-
             var feedback_group = display.get_compositor ().get_feedback_group ();
             stage.remove_child (feedback_group);
             ui_group.add_child (feedback_group);