Add panel hide delay #2103
Merged
Add panel hide delay #2103
+125
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing ! Thank you :) I look forward to this ! |
alainm23
approved these changes
Oct 31, 2024
leolost2605
requested changes
Oct 31, 2024
leolost2605
requested changes
Nov 2, 2024
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
A few things but apart from that looks good and thanks for the cleanup wanted to do it since the original got merged but never found time :)
leolost2605
reviewed
Nov 2, 2024
|
Hello ! |
Member
|
Yeah I think it's pretty much ready but we have a small disagreement on a style choice so we are kinda looking for a third party to decide :) |
leolost2605
approved these changes
Nov 11, 2024
|
thank you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elementary/dock#300
This required a small code refactor. All show/hide trigger logic (including barriers) now located in HideTracker. This ensures that all the hide/show signals don't interrupt each other.