Introduce a WindowListModel #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
changed the title
Member
Author
|
This should be ready for review now and thorough testing would be appreciated :) |
lenemter
requested changes
Oct 10, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
This is great! I always wanted to get rid of these endless signal chains in multitasking view code. I left 2 questions/suggestions. Once they're resolved I'll be happy to merge this
lenemter
reviewed
Oct 13, 2025
lenemter
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2353
Introduce a window list model that allows us to collect the filtering and sorting code for different views of the current window list in a single place
Since this window list model now also guarantees that all windows that appear in it have a valid actor i.e. get_compositor_private won't return null this will allow for a bunch of clean up in a follow up :)
This should also help quite a bit with #2522 to allow more deduplication there