Address review comments

Author: danirabbit

src/MainWindow.vala

@@ -31,8 +31,7 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
 
         repeat_button = new Gtk.Button ();
 
-        ListModel list_model;
-        search_bar = new SearchBar (playback_manager.queue_liststore, out list_model);
+        search_bar = new SearchBar (playback_manager.queue_liststore);
 
         search_revealer = new Gtk.Revealer () {
             child = search_bar
@@ -60,7 +59,7 @@ public class Music.MainWindow : Gtk.ApplicationWindow {
             icon = new ThemedIcon ("edit-find-symbolic")
         };
 
-        selection_model = new Gtk.SingleSelection (list_model);
+        selection_model = new Gtk.SingleSelection (search_bar.filter_model);
 
         var factory = new Gtk.SignalListItemFactory ();
 

src/Widgets/SearchBar.vala

@@ -10,17 +10,16 @@ public class Music.SearchBar : Granite.Bin {
 
     public Gtk.SearchEntry search_entry { get; private set; }
 
-    private Gtk.StringFilter filter;
-    private Gtk.FilterListModel filter_model;
-
     /**
-     * @param new_model the new model with the search applied. Make sure to use this one in further UI
+     * The new model with the search applied. Make sure to use this one in further UI
      * instead of the old given model.
      */
-    public SearchBar (ListModel list_model, out ListModel new_model) {
-        Object (list_model: list_model);
+    public Gtk.FilterListModel filter_model { get; private set; }
 
-        new_model = filter_model;
+    private Gtk.StringFilter filter;
+
+    public SearchBar (ListModel list_model) {
+        Object (list_model: list_model);
     }
 
     construct {