Skip to content

Commit 6746fd5

Browse files
committed
Wallpaper: sort in model, not flowbox
1 parent 2aaba38 commit 6746fd5

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

src/Views/Wallpaper.vala

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public class PantheonShell.Wallpaper : Switchboard.SettingsPage {
6666
wallpaper_view.bind_model (wallpaper_model, create_widget_func);
6767
wallpaper_view.add_css_class (Granite.STYLE_CLASS_VIEW);
6868
wallpaper_view.child_activated.connect (update_checked_wallpaper);
69-
wallpaper_view.set_sort_func (wallpapers_sort_function);
7069
wallpaper_view.add_controller (drop_target);
7170

7271
var color = gnome_background_settings.get_string ("primary-color");
@@ -229,7 +228,7 @@ public class PantheonShell.Wallpaper : Switchboard.SettingsPage {
229228
set_combo_disabled_if_necessary ();
230229
create_solid_color_container (color_button.rgba.to_string ());
231230

232-
wallpaper_model.append (solid_color);
231+
wallpaper_model.insert_sorted (solid_color, wallpapers_sort_function);
233232

234233
wallpaper_view.select_child (solid_color);
235234

@@ -403,7 +402,7 @@ public class PantheonShell.Wallpaper : Switchboard.SettingsPage {
403402
var thumb_path = info.get_attribute_as_string (FileAttribute.THUMBNAIL_PATH);
404403
var thumb_valid = info.get_attribute_boolean (FileAttribute.THUMBNAIL_IS_VALID);
405404
var wallpaper = new WallpaperContainer (uri, thumb_path, thumb_valid);
406-
wallpaper_model.append (wallpaper);
405+
wallpaper_model.insert_sorted (wallpaper, wallpapers_sort_function);
407406

408407
wallpaper.trash.connect (() => {
409408
send_undo_toast ();
@@ -430,9 +429,9 @@ public class PantheonShell.Wallpaper : Switchboard.SettingsPage {
430429
}
431430
}
432431

433-
private int wallpapers_sort_function (Gtk.FlowBoxChild _child1, Gtk.FlowBoxChild _child2) {
434-
var child1 = (WallpaperContainer) _child1;
435-
var child2 = (WallpaperContainer) _child2;
432+
private int wallpapers_sort_function (Object object1, Object object2) {
433+
var child1 = (WallpaperContainer) object1;
434+
var child2 = (WallpaperContainer) object2;
436435
var uri1 = child1.uri;
437436
var uri2 = child2.uri;
438437

0 commit comments

Comments
 (0)