[libadwaita] Issues found while browsing adwaita-1-demo

[ethanc8]

On KDE Plasma Wayland on openSUSE Slowroll, with elementary/stylesheet from git and libadwaita 1.7.6 built from source, I found a few issues. For each of these, I will try to find the appropriate issue if it's already been raised.

On each screenshot, on the left is io.elementary.stylesheet.lime and on the right is the libadwaita stylesheet, with accent color #288417 applied by kde-gtk-config.

Important pages

Lists

• The image in the center of the radiobutton is missing. libadwaita radiobutton and checkbox styling issues #1335
• The spin row has unnecessary and inelegant borders. Entry in AdwSpinRow looks too wide #1320

• The emphasis on the property row is wrong (the data should be more prominent than the title). [libadwaita] Incorrect emphasis on property row #1336
• The button rows are not styled at all. Styles missing for AdwToggleGroup #1324

Style classes

• The left-arrow and right-arrow buttons are missing. [libadwaita] OSD-styled arrow buttons on "style classes" demo page #1337
• The backgrounds of the success, warning, and error textfields are not colored. [libadwaita] GtkEntry with success, warning, and error #1338
• The toggle groups are not styled. Styles missing for AdwToggleGroup #1324

• The titles are not bold and large, and the caption is not small and greyed out. (related to Add new Gtk text style classes #518)
• The activatable card should look like the card button.
• The activatable row does not give feedback when pressed.

• The app icons are missing their drop shadows.
• The checkboxes are missing their interiors, and the selection mode checkboxes are not larger or round. libadwaita radiobutton and checkbox styling issues #1335
• The toolbar is inelegant, cramped, and has visual artifacts.
• The media player icons are black rather than white (although the official stylesheet still has issues with the volume button).

Not pictured:

• The "development window" style does not make any change to the appearance of the titlebar.
• The OSD progress bar is large and clunky.

Other pages

Clamp

The issue is with the spin row (see Lists)

View switcher

The badge on the stopwatch should be highlighted, rather than the stopwatch itself.

Tab view

The backgrounds of some tabs are uncolored.

Buttons

• The title is not bolded or large.
• The buttons are not joined together (this could probably be achieved using the linked style).
• The borderless buttons have borders (however, it could be argued that borderless buttons are not compliant with good practice or with the style of the elementaryOS stylesheet)

Toast

• The button on the toast is light when it should be dark. (related to Adw.Toast is not styled #1285)

Animations

• The toggle group is not styled. Styles missing for AdwToggleGroup #1324
• The ball to be animated does not appear.

Alert

• The alert dialog is very cramped and clunky.

Banner

• The banner is not styled.

Toggle groups

• The title is not large and bold.
• The toggle groups are not styled. Styles missing for AdwToggleGroup #1324

Wrap groups

• It may be better to make the buttons less conspicuous.

[ryonakano]

@ethanc8

I found a few issues. For each of these, I will try to find the appropriate issue if it's already been raised.

Please check if each of your issue is already reported before reporting and then submit ones that has not been reported yet in separated issues.

[ethanc8]

@ethanc8

I found a few issues. For each of these, I will try to find the appropriate issue if it's already been raised.

Please check if each of your issue is already reported before reporting and then submit ones that has not been reported yet in separated issues.

I think it is valuable to have a single issue showing all of the things visible in adwaita-1-demo. I will try to raise separate issues for the ones that are not reported yet, but I cannot entirely identify the technical reasons behind each issue.