"Please report the incident to Pantheon Terminal developers" after launching another terminal from CLI

[utf-4096]

What Happened?

When launching a different terminal emulator (Alacritty, XTerm, ...) from inside Pantheon Terminal, this message appears:

You should not have seen this, please report the incident to the Pantheon Terminal developers.

The launched terminal also causes a "Process completed" notification for every command executed.

Steps to Reproduce

1. Install either Alacritty or XTerm
2. Open Terminal
3. Run alacritty or xterm, run some commands
4. See notifications

Expected Behavior

No notifications.

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

Hardware Info

• Using fish as shell

[jeremypw]

The first message is associated with using fish as shell. The code is commented:

# Some shells (e.g. BASH) lack the post-execution hook,
# so we insert a callback into their pre-prompt hook instead.
# This results in a bogus callback on first prompt, which has to be ignored.
# We've tried some clever focus-based suppression but it was prone to race conditions.
# The only reliable way to work that around that we've found
# is always ignoring the first callback in each tab on the terminal side
# and deliberately issuing a fake callback from shells with a proper
# post-execution hook, such zsh and fish.

This is a duplicate of issue #360 so no solution has been developed for quite some time. See also fish-shell/fish-shell#1382 and #243. Maybe its time to have another look at this ...