Suppress tooltips when popover is open (#393)

* Suppress tooltip when popover is open

* Use unowned keyword for display widget vars

* Suppress tooltips using "has-tooltip" (#1)

* Simplify by using "has-tooltip" property

* Remove unused code.

* Use the visible property of the popover widget.

* null-check the display_widget and DRY.

* Fix warning about unowned being default in this context.

* Update PopoverManager.vala

Rename `suppress_tooltip ()` function to `update_has_tooltip ()`

Co-authored-by: Jeremy Wootten <[email protected]>

Author: vjr

src/Services/PopoverManager.vala

@@ -45,20 +45,23 @@ public class Wingpanel.Services.PopoverManager : Object {
                 _current_indicator.base_indicator.closed ();
                 _current_indicator = null;
             } else { // Switch
+                update_has_tooltip (_current_indicator.display_widget);
                 _current_indicator.base_indicator.closed ();
                 _current_indicator = value;
             }
 
             if (_current_indicator != null) {
                 popover.set_content (_current_indicator.indicator_widget);
                 popover.relative_to = _current_indicator;
+                update_has_tooltip (_current_indicator.display_widget, false);
                 owner.set_expanded (true);
                 make_modal (popover, true);
                 owner.present ();
                 popover.popup ();
                 popover.show_all ();
                 _current_indicator.base_indicator.opened ();
             } else {
+                update_has_tooltip (((Wingpanel.Widgets.IndicatorEntry)popover.get_relative_to ()).display_widget);
                 popover.popdown ();
             }
         }
@@ -165,6 +168,12 @@ public class Wingpanel.Services.PopoverManager : Object {
         return current_indicator != null && current_indicator.base_indicator.code_name == entry.base_indicator.code_name;
     }
 
+    private void update_has_tooltip (Gtk.Widget display_widget, bool enable = true) {
+        if (display_widget != null) {
+            display_widget.has_tooltip = enable;
+        }
+    }
+
     private void make_modal (Gtk.Popover? pop, bool modal = true) {
         if (pop == null || pop.get_window () == null || mousing) {
             return;