Merge branch '235-github-actions-workflow-faalt' into 'main'

Resolve "Github actions workflow faalt"

See merge request elgentos/magento2-playwright!37

Author: Shay

.github/workflows/main.yml

@@ -8,7 +8,7 @@ on:
 jobs:
   build-and-selftest:
     if: github.head_ref != 'gitlab-main'
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
 
     env:
       PLAYWRIGHT_BASE_URL: https://hyva-demo.elgentos.io/
@@ -41,31 +41,48 @@ jobs:
         with:
           node-version: 18
 
-      - name: Install dependencies
-        run: npm install
-
-      - name: Install Playwright browsers
-        run: npx playwright install --with-deps
-
       - name: Copy config files
         run: |
           cp playwright.config.example.ts playwright.config.ts
           cp bypass-captcha.config.example.ts bypass-captcha.config.ts
-          cp tests.config.example.ts tests.config.ts
           cp tsconfig.example.json tsconfig.json
 
-      - name: Run Playwright setup test
-        run: npx playwright test --reporter=line --workers=4 tests/setup.spec.ts
+      - name: Create testing suite environment
+        run: |
+            set -euo pipefail
+            echo 'Setting up the testing environment'
+            mkdir -p base-tests
+            npm install
+            npx playwright install-deps
+            ls -l base-tests
+            npx playwright test --grep "@setup" --reporter=line --workers=4 --max-failures=1
+        shell: bash
         env:
-          CI: true
+            CI: true
+      - uses: actions/upload-artifact@v4
+        if: ${{ !cancelled() }}
+        with:
+            name: playwright-report
+            path: playwright-report
+            retention-days: 30
 
       - name: Run Playwright tests
-        run: npx playwright test --workers=4 --grep-invert "@setup" --max-failures=1
+        run: |
+            set -euo pipefail
+            echo "Running tests from testing suite"
+            npx playwright install --with-deps
+            npx playwright test --workers=4 --grep-invert "@setup" --max-failures=1
         env:
-          CI: true
+            CI: true
+      - uses: actions/upload-artifact@v4
+        if: ${{ !cancelled() }}
+        with:
+            name: playwright-report
+            path: playwright-report
+            retention-days: 30
       - uses: actions/upload-artifact@v4
         if: ${{ !cancelled() }}
         with:
-          name: playwright-report
-          path: playwright-report/
-          retention-days: 30
+            name: test-results
+            path: test-results
+            retention-days: 30

tests/poms/adminhtml/magentoAdmin.page.ts

@@ -186,7 +186,7 @@ class MagentoAdminPage {
     await customerConfigurationLink.waitFor();
     await customerConfigurationLink.click();
 
-    const captchaSettingsBlock = this.page.getByRole('link', { name: UIReference.configurationPage.captchaSectionLabel });
+    const captchaSettingsBlock = this.page.getByRole('link', { name: UIReference.configurationPage.captchaSectionLabel }).filter({hasNotText: 'documentation'});
     const captchaSettingsSystemValueCheckbox = this.page.locator(UIReference.configurationPage.captchaSettingSystemCheckbox);
 
     await captchaSettingsBlock.waitFor();

tests/poms/frontend/login.page.ts

@@ -27,6 +27,8 @@ class LoginPage {
     await this.loginButton.press("Enter");
     // await this.loginButton.click({force: true});
 
+    await this.page.waitForURL(slugs.account.accountOverviewSlug);
+
     // Open the menu, then check the 'Sign Out' button is visible
     await mainmenu.mainMenuAccountButton.waitFor();
     await mainmenu.mainMenuAccountButton.click();

tests/poms/frontend/product.page.ts

@@ -43,6 +43,10 @@ class ProductPage {
     await this.addToWishlistButton.click();
     await this.page.waitForLoadState();
 
+    await expect(async () => {
+      await expect(this.page.getByText(addedToWishlistNotification)).toBeVisible();
+    }).toPass();
+
     let productNameInWishlist = this.page.locator(UIReference.wishListPage.wishListItemGridLabel).getByText(UIReference.productPage.simpleProductTitle, {exact: true});
 
     await expect(this.page).toHaveURL(new RegExp(slugs.wishlist.wishListRegex));