Skip to content

Commit 7011a76

Browse files
authored
Merge pull request #12 from Vendic/feature/add-rum-prefix
Add RUM prefix to tracking id
2 parents 80b7523 + 8d7f41c commit 7011a76

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/ViewModel/Rumvision.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ public function shouldIncludeScript(): bool
2727

2828
public function getTrackingId() :string
2929
{
30-
return $this->configuration
31-
->getTrackingId();
30+
$trackingId = $this->configuration->getTrackingId();
31+
return str_starts_with($trackingId, 'RUM-') ? $trackingId : sprintf('RUM-%s', $trackingId);
3232
}
3333

3434
public function getHostName() :string

src/view/frontend/templates/script/rumvision.phtml

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ if (! $viewModel->shouldIncludeScript()) {
2121
if ( s.urls && s.regex && ( s.page = eval('('+s.regex+')')( s.urls, vi.location.pathname ) ) && !s.page.type ) {
2222
return sessionStorage.setItem('rumv', JSON.stringify( s ) );
2323
}
24-
24+
2525
vi.rumv.storage = s;
2626
var head = si.querySelector('head'), js = si.createElement('script');
2727
js.src = 'https://d5yoctgpv4cpx.cloudfront.net/'+rum+'/v4-'+vi.location.hostname+'.js';
2828
head.appendChild(js);
29-
})( 'RUM-<?= $escaper->escapeJs($viewModel->getTrackingId()) ?>', window, document, '<?= $escaper->escapeJs($viewModel->getHostName()) ?>' );
29+
})( '<?= $escaper->escapeJs($viewModel->getTrackingId()) ?>', window, document, '<?= $escaper->escapeJs($viewModel->getHostName()) ?>' );
3030
</script>

0 commit comments

Comments
 (0)