Fix bug where all non-duplicated keys are reported as duplicates

elijah-santos · web-flow · commit 79f985253fd1 · 2024-12-16T12:20:19.000-08:00
This only printed an error message (no errors in functionality), but is definitely annoying
diff --git a/Sources/AttachmentsEverywhere/API/Attachments/AttachmentContentBuilder.swift b/Sources/AttachmentsEverywhere/API/Attachments/AttachmentContentBuilder.swift
@@ -34,7 +34,7 @@ public enum AttachmentContentBuilder {
     public static func buildPartialBlock(accumulated: AttachmentContent, next: AttachmentContent) -> AttachmentContent {
         var res = accumulated
         for (key, value) in next {
-            if next.contains(where: { $0.key == key }) {
+            if accumulated.contains(where: { $0.key == key }) {
                 print("[AttachmentsEverywhere] warning: duplicate key in attachment content: \(String(reflecting: key))")
             }
             res[key] = value

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public enum AttachmentContentBuilder {`
`34`	`34`	`public static func buildPartialBlock(accumulated: AttachmentContent, next: AttachmentContent) -> AttachmentContent {`
`35`	`35`	`var res = accumulated`
`36`	`36`	`for (key, value) in next {`
`37`		`- if next.contains(where: { $0.key == key }) {`
	`37`	`+ if accumulated.contains(where: { $0.key == key }) {`
`38`	`38`	`print("[AttachmentsEverywhere] warning: duplicate key in attachment content: \(String(reflecting: key))")`
`39`	`39`	`}`
`40`	`40`	`res[key] = value`