Skip to content

Commit 1b54958

Browse files
committed
fix(bench): keep hero heading in renderAllEmpty for UX consistency
When the snapshot fallback chain fully fails, renderAllEmpty was emitting just an error <p> for the hero panel while still emitting <h4> titles for each throughput panel — an inconsistent layout where the hero heading vanishes on error but section headings stay. Add the standard 'Throughput at a glance' <h3> before the error message so the page structure is identical between healthy and empty states. Addresses Momus BOT-A2 (Low).
1 parent 656974c commit 1b54958

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

docs/assets/bench-charts.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,6 +1019,8 @@
10191019
const heroHost = document.getElementById('bench-hero');
10201020
if (heroHost) {
10211021
heroHost.innerHTML = '';
1022+
heroHost.appendChild(el('h3', { class: 'bench-hero-heading' },
1023+
'Throughput at a glance'));
10221024
heroHost.appendChild(el('p', { class: 'bench-hero-empty' },
10231025
'Bench snapshot pending — ' + reason));
10241026
}

0 commit comments

Comments
 (0)