Skip to content

Commit f78147c

Browse files
authored
Add number symbol (#2319)
2 parents 14cc508 + 7b5d45d commit f78147c

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

pom-dependency-tree.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
ai.elimu:webapp:war:2.6.112-SNAPSHOT
2-
+- ai.elimu:model:jar:model-2.0.118:compile
1+
ai.elimu:webapp:war:2.6.113-SNAPSHOT
2+
+- ai.elimu:model:jar:model-2.0.119:compile
33
| \- com.google.code.gson:gson:jar:2.13.1:compile
44
| \- com.google.errorprone:error_prone_annotations:jar:2.38.0:compile
55
+- org.springframework:spring-context:jar:6.0.11:compile

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<properties>
1010
<java.version>17</java.version>
1111
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
12-
<model.version>2.0.118</model.version>
12+
<model.version>2.0.119</model.version>
1313
<hibernate.version>6.1.7.Final</hibernate.version>
1414
<jetty.version>11.0.24</jetty.version>
1515
<spring.version>6.0.11</spring.version>

src/main/java/ai/elimu/entity/analytics/NumberAssessmentEvent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class NumberAssessmentEvent extends AssessmentEvent {
1919
private Integer numberValue;
2020

2121
/**
22-
* The number represented as a symbol specific to the language. E.g. <code>"१०"</code>.
22+
* The number represented as a symbol specific to the language. E.g. "१०" for <code>10</code> in Hindi.
2323
*/
2424
private String numberSymbol;
2525

src/main/java/ai/elimu/util/csv/CsvAnalyticsExtractionHelper.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,8 +544,13 @@ public static List<NumberAssessmentEvent> extractNumberAssessmentEvents(File csv
544544
Integer numberValue = Integer.valueOf(csvRecord.get("number_value"));
545545
numberAssessmentEvent.setNumberValue(numberValue);
546546

547-
// String numberSymbol = csvRecord.get("number_symbol");
548-
// numberAssessmentEvent.setNumberSymbol(numberSymbol);
547+
if (versionCode >= 4001005) {
548+
// https://github.com/elimu-ai/analytics/releases/tag/4.1.5
549+
if (StringUtils.isNotBlank(csvRecord.get("number_symbol"))) {
550+
String numberSymbol = csvRecord.get("number_symbol");
551+
numberAssessmentEvent.setNumberSymbol(numberSymbol);
552+
}
553+
}
549554

550555
if (StringUtils.isNotBlank(csvRecord.get("number_id"))) {
551556
Long numberId = Long.valueOf(csvRecord.get("number_id"));

0 commit comments

Comments
 (0)