Skip to content

Commit db205fc

Browse files
committed
Syntax changes
1 parent 4408d80 commit db205fc

File tree

2 files changed

+21
-20
lines changed

2 files changed

+21
-20
lines changed

src/pytest_pl_grader/fixture.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -222,18 +222,18 @@ def try_drop_privileges() -> None:
222222
setup_code = self.setup_code_file.read_text(encoding="utf-8")
223223

224224
# TODO make this a shared type
225-
json_message: ProcessStartRequest = {
226-
"message_type": "start",
227-
"student_code": student_code,
228-
"student_file_name": str(self.student_code_file),
229-
"setup_code": setup_code,
230-
"initialization_timeout": initialization_timeout,
231-
"import_whitelist": self.import_whitelist,
232-
"import_blacklist": self.import_blacklist,
233-
"starting_vars": self.starting_vars,
234-
"builtin_whitelist": self.builtin_whitelist,
235-
"names_for_user_list": self.names_for_user_list,
236-
}
225+
json_message = ProcessStartRequest(
226+
message_type="start",
227+
student_code=student_code,
228+
student_file_name=str(self.student_code_file),
229+
setup_code=setup_code,
230+
initialization_timeout=initialization_timeout,
231+
import_whitelist=self.import_whitelist,
232+
import_blacklist=self.import_blacklist,
233+
starting_vars=self.starting_vars,
234+
builtin_whitelist=self.builtin_whitelist,
235+
names_for_user_list=self.names_for_user_list,
236+
)
237237

238238
assert self.process.stdout is not None, "Process stdout is None. Ensure the process is started correctly."
239239

@@ -286,7 +286,7 @@ def query_setup(self, var_to_query: str) -> Any:
286286
def query_raw(self, var_to_query: str, *, query_timeout: float = DEFAULT_TIMEOUT) -> StudentQueryResponse:
287287
self._assert_process_running()
288288

289-
json_message: StudentQueryRequest = {"message_type": "query", "var": var_to_query, "query_timeout": query_timeout}
289+
json_message = StudentQueryRequest(message_type="query", var=var_to_query, query_timeout=query_timeout)
290290

291291
assert self.student_socket is not None, "Student socket is not connected. Please start the student code server first."
292292
self.student_socket.settimeout(query_timeout)
@@ -311,13 +311,13 @@ def query_function_raw(self, function_name: str, *args, query_timeout: float = D
311311
TODO add query timeout keyword only argument
312312
"""
313313

314-
json_message: StudentFunctionRequest = {
315-
"message_type": "query_function",
316-
"function_name": function_name,
317-
"args_encoded": serialize_object_unsafe(args),
318-
"kwargs_encoded": serialize_object_unsafe(kwargs),
319-
"query_timeout": query_timeout,
320-
}
314+
json_message = StudentFunctionRequest(
315+
message_type="query_function",
316+
function_name=function_name,
317+
args_encoded=serialize_object_unsafe(args),
318+
kwargs_encoded=serialize_object_unsafe(kwargs),
319+
query_timeout=query_timeout,
320+
)
321321

322322
assert self.student_socket is not None, "Student socket is not connected. Please start the student code server first."
323323
self.student_socket.settimeout(query_timeout)

src/pytest_pl_grader/plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ def sandbox(request: pytest.FixtureRequest, data_json: dict[str, Any] | None) ->
129129

130130
try:
131131
# TODO make sure to read student output and include in the exception message
132+
# TODO also get this configuration by reading from the marker
132133
response = fixture.start_student_code_server(initialization_timeout=initialization_timeout)
133134
response_status = response["status"]
134135

0 commit comments

Comments
 (0)