Theocracy - Fails to load with EnableDdrawWrapper

[RibShark]

The game "Theocracy" fails to load when dxwrapper is installed, both with and without Dd7to9. The game is able to create a window and change the mode before silently crashing, with some errors in the log:

36828 19:20:25.758 Starting DxWrapper v1.7.8400.25
36828 19:20:25.759 Running from: X:\Theocracy\dxwrapper.dll (78410000)
36828 19:20:25.759 Reading config file: X:\Theocracy\dxwrapper.ini
36828 19:20:25.759 NVIDIA GeForce RTX 5080
36828 19:20:25.760 Windows 10 Enterprise 64-bit (10.0.26100)
36828 19:20:25.760 Windows 11 64-bit (10.0.26100)
36828 19:20:25.760 theocracy-0.6.85.exe (PID:16072)
36828 19:20:25.760 "X:\Theocracy\theocracy-0.6.85.exe" 
36828 19:20:25.767 Environment variable __COMPAT_LAYER = ""
36828 19:20:25.767 Windows is newer than, Windows Vista: 1 Windows 7: 1 Windows 8: 1
36828 19:20:25.768 Disabling High DPI Scaling...
36828 19:20:25.768 Loaded library: user32.dll
36828 19:20:25.768 Loaded library: shcore.dll
36828 19:20:25.768 Hooking ole32.dll APIs...
36828 19:20:25.768 Loading d3dx9 libraries
36828 19:20:25.773 Loading 'ddraw.dll'...
36828 19:20:25.773 Hooking ddraw.dll APIs...
36828 19:20:25.774 Loaded library: d3d9.dll
36828 19:20:25.774 Enabling d3d9 wrapper
36828 19:20:25.774 Loading 'd3d9.dll'...
36828 19:20:25.774 Loaded library: winmm.dll
36828 19:20:25.776 Installing memory management hooks
36828 19:20:25.776 Installing messaging hooks
36828 19:20:25.776 Installing version hooks
36828 19:20:25.776 Installing display mode hooks
36828 19:20:25.776 Installing registry hooks
36828 19:20:25.777 Installing Win32 hooks
36828 19:20:25.777 Installing GDI & User32 hooks
36828 19:20:25.777 Installing Kernel32 hooks
36828 19:20:25.777 DxWrapper loaded!
36828 19:20:25.777 DxWrapperLogging DxWrapper loaded by stub: ddraw.dll
36828 19:20:25.777 dd_DirectDrawCreate
36828 19:20:25.778 Redirecting 'DirectDrawCreate' to --> 'Direct3DCreate9'
36828 19:20:25.778 Direct3D9SetSwapEffectUpgradeShim Calling 'Direct3D9SetSwapEffectUpgradeShim' ... 0
36828 19:20:25.778 Creating interface m_IDirectDrawX::m_IDirectDrawX (009E7D18) converting interface from v1 to v9
36828 19:20:25.778 d9_Direct3DCreate9
36828 19:20:25.778 Redirecting 'Direct3DCreate9' ...
36828 19:20:25.865 Creating interface m_IDirect3D9Ex::m_IDirect3D9Ex (04430660) IID_IDirect3D9
36828 19:20:25.866 m_IDirect3D9Ex::LogAdapterNames Adapter: 0 \\.\DISPLAY1 NVIDIA GeForce RTX 5080
36828 19:20:25.866 m_IDirect3D9Ex::LogAdapterNames Adapter: 1 \\.\DISPLAY2 NVIDIA GeForce RTX 5080
36828 19:20:25.866 WndProc::AddWndProc Creating WndProc instance! WND(002E09BC,Bagoy,{0,0,2752,1152})
36828 19:20:25.866 m_IDirectDrawX::CreateD9Device Direct3D9 device! 6000x1440 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(002E09BC,Bagoy,{0,0,2752,1152}) params: {6000,1440,D3DFMT_UNKNOWN,1,0,0,3,WND(002E09BC,Bagoy,{0,0,2752,1152}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
36828 19:20:25.868 m_IDirect3D9Ex::AdjustWindowStyle Warning: adding WS_EX_APPWINDOW
36828 19:20:25.868 WndProc::Handler Warning: filtering some messages when creating device. WND(002E09BC,Bagoy,{0,0,2752,1152}) 0x7c 4294967276 1761932 IsIconic: 0
36828 19:20:25.868 WndProc::Handler Warning: filtering some messages when creating device. WND(002E09BC,Bagoy,{0,0,2752,1152}) 0x7d 4294967276 1761932 IsIconic: 0
36828 19:20:25.968 Creating interface m_IDirect3DDevice9Ex::m_IDirect3DDevice9Ex (0CB6DC00) IID_IDirect3DDevice9 game interface v1
36828 19:20:25.997 m_IDirectDrawX::CreateD9Device Direct3D9 device! 3440x1440 refresh: 0 format: D3DFMT_X8R8G8B8 wnd: WND(002E09BC,Bagoy,{0,0,2752,1152}) params: {3440,1440,D3DFMT_X8R8G8B8,1,0,0,1,WND(002E09BC,Bagoy,{0,0,2752,1152}),0,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
36828 19:20:25.997 m_IDirectDrawX::CreateD9Device Recreate device! Last create: WND(002E09BC,Bagoy,{0,0,2752,1152})->WND(002E09BC,Bagoy,{0,0,2752,1152})  Windowed: 1->0 6000x1440->3440x1440 0x46->0x46
36828 19:20:26.003 m_IDirect3DDevice9Ex::~m_IDirect3DDevice9Ex (0CB6DC00) deleting interface!
36828 19:20:26.121 WndProc::Handler Warning: filtering some messages when creating device. WND(002E09BC,Bagoy,{0,0,2752,1152}) 0x5 0 75500224 IsIconic: 0
36828 19:20:26.149 WndProc::Handler Warning: filtering some messages when creating device. WND(002E09BC,Bagoy,{0,0,3440,1440}) 0x5 0 94375280 IsIconic: 0
36828 19:20:26.160 WndProc::Handler Warning: filtering some messages when creating device. WND(002E09BC,Bagoy,{0,0,3440,1440}) 0x7c 4294967280 1768484 IsIconic: 0
36828 19:20:26.427 Creating interface m_IDirect3DDevice9Ex::m_IDirect3DDevice9Ex (0CC9BEB8) IID_IDirect3DDevice9 game interface v4
33156 19:20:26.570 CoCreateInstanceHandle CLSID_MMDeviceEnumerator -> IID_IMMDeviceEnumerator
35928 19:20:26.603 CoCreateInstanceHandle CLSID_MMDeviceEnumerator -> IID_IMMDeviceEnumerator
36828 19:20:26.623 CoCreateInstanceHandle CLSID_MMDeviceEnumerator -> IID_IMMDeviceEnumerator
36828 19:20:26.668 m_IDirectDrawX::CreateD9Device Direct3D9 device! 640x480 refresh: 0 format: D3DFMT_X8R8G8B8 wnd: WND(002E09BC,Bagoy,{0,0,3440,1440}) params: {640,480,D3DFMT_X8R8G8B8,1,0,0,1,WND(002E09BC,Bagoy,{0,0,3440,1440}),0,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
36828 19:20:26.668 m_IDirectDrawX::CreateD9Device Resetting device! Last create: WND(002E09BC,Bagoy,{0,0,3440,1440})->WND(002E09BC,Bagoy,{0,0,3440,1440})  Windowed: 0->0 3440x1440->640x480 0x46->0x46
36828 19:20:27.007 m_IDirect3DDevice9Ex::ResetT Disabling AntiAliasing...
36828 19:20:27.669 m_IDirectDrawX::CreateSurface2 Primary surface D3DFMT_UNKNOWN 0x0 dwFlags: 0x1 ddsCaps: 0x200, 0x0, 1
36828 19:20:27.669 Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (0CD9F7F8) converting interface from v1 to v9
36828 19:20:27.669 dd_AcquireDDThreadLock
36828 19:20:27.669 dd_ReleaseDDThreadLock
36828 19:20:27.669 Error occurred in the application: code=0xC0000005 flags=0x00000000 addr=579B5885 rw=0 bad=00000004 module=C:\Windows\System32\ddrawex.dll Registers: EIP=0x579B5885 ECX=0x0002848E EAX=0x00000000

It seems to fail somewhere in a IDirectDraw::CreateSurface() call in ddrawex.dll. dxwrapper does not appear in the stack trace.

Possibly relevant issue here in DDrawCompat: narzoul/DDrawCompat#349
(between this and the game using IDirectDrawFactory it does seem to do some very unusual things)

[RibShark]

It seems code needs to be added to CoCreateInstanceHandle to deal with IDirectDrawFactory; I added code for the non-Dd7to9 path and now dxwrapper is properly in the stack trace but the game still crashes with the surface creation.

I tried adding similar code to the Dd7to9 path (though there is no dd_DirectDrawFactoryCreate function so I just used new (std::nothrow) m_IDirectDrawFactory); I had to comment out lines 183-188 in m_IDirectDrawX::QueryInterface but after that it does seem to with with Dd7to9. I don't think this is the correct way to go about it though; you probably know better.

[elishacloud]

Thanks. I added support for IDirectDrawFactory in the latest build. However, I have no way to test it. Let me know if you have any issues with it.

[RibShark]

Still fails to query IDirectDraw3 due to the lines in m_IDirectDrawX:QueryInterface that block it. IDirectDrawFactory is used to create an IDirectDraw interface that is then queried for an IDirectDraw3 interface; DirectXVersion == 1 in this case so the check fails and it returns E_NOINTERFACE. What needs to happen is to additionally pass the check if the IDirectDraw interface was created with IDirectDrawFactory.

In addition the game still crashes when Dd7to9 is disabled and EnableDdrawWrapper is enabled. Without wrapping Ddraw the game will boot successfully as long as single processor affinity is forced. Log file for this: dxwrapper-theocracy-0.6.85.log

[elishacloud]

Still fails to query IDirectDraw3 due to the lines in m_IDirectDrawX:QueryInterface that block it.

I added a block for IDirectDraw3 to replicate native DirectDraw. It also fails. However, I added an update to allow it from IDirectDrawFactory. I guess it should work in that case.

In addition the game still crashes when Dd7to9 is disabled and EnableDdrawWrapper is enabled.

This is kind of weird. I am only seeing 4 exports in ddrawex.dll and none of these should crash inside them. Let me hook these functions and see what I can do:

• DllCanUnloadNow
• DllGetClassObject
• DllRegisterServer
• DllUnregisterServer

[elishacloud]

This should work with Dd7to9 in the latest Action build. Let me know if you're still having problems here.

As far as fixing this when only EnableDdrawWrapper enabled, I may look at this later but for now I'm not going to fix it for now.

[RibShark]

Yep, can confirm it works with Dd7to9 now. Will leave this open since EnableDdrawWrapper still crashes.

[elishacloud]

Ok, I made a change that might fix this when only EnableDdrawWrapper is enabled. This is a debug build. If it works please let me know. If it doesn't work, please up load the log files here.

Here is the test build: dxwrapper.zip