Skip to content

Commit d42688c

Browse files
author
Leo B
committed
Fix warnings in preloader tests by adding explicit on-clauses
1 parent 1573854 commit d42688c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: integration_test/cases/preload.exs

+4-2
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,8 @@ defmodule Ecto.Integration.PreloadTest do
433433
TestRepo.all(
434434
from c in CompositePk,
435435
join: cc in "composite_pk_composite_pk",
436-
where: cc.a_1 in ^composite_ids_a and cc.b_1 in ^composite_ids_b and cc.a_2 == c.a and cc.b_2 == c.b,
436+
on: cc.a_2 == c.a and cc.b_2 == c.b,
437+
where: cc.a_1 in ^composite_ids_a and cc.b_1 in ^composite_ids_b,
437438
order_by: [c.a, c.b],
438439
select: map(c, [:name])
439440
)
@@ -449,7 +450,8 @@ defmodule Ecto.Integration.PreloadTest do
449450
TestRepo.all(
450451
from c in CompositePk,
451452
join: cc in "composite_pk_composite_pk",
452-
where: cc.a_1 in ^composite_ids_a and cc.b_1 in ^composite_ids_b and cc.a_2 == c.a and cc.b_2 == c.b,
453+
on: cc.a_2 == c.a and cc.b_2 == c.b,
454+
where: cc.a_1 in ^composite_ids_a and cc.b_1 in ^composite_ids_b,
453455
order_by: [c.a, c.b],
454456
select: {[cc.a_1, cc.b_1], map(c, [:name])}
455457
)

0 commit comments

Comments
 (0)