Skip to content

Fix action buttons #145

Open
Open
@jaimeiniesta

Description

@jaimeiniesta

Hi, I was trying the new mute action and it caught my attention that, while the Resolve / Unresolve action is a button, the new Mute / Unmute action is a link. Both should be buttons, as they trigger actions, aren't used for navigation.

Making both actions as button provides a unified experience when using the keyboard, as buttons can be triggered using the space and return keys, whereas links can't be triggered with the space key.

I'm working on a PR that also fixes the Unmute action as it's currently broken in two lines.

Image

Here's my work in progress, as soon as I fix the responsive design for it I'll send a PR if that's OK.

Grabacion.de.pantalla.2025-03-28.a.las.15.32.00.mov

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions