Skip to content

[BUG]: 'INVALID' in Web UI instead of server 500 errors #86

@M-casado

Description

@M-casado

Bug summary

Proper connection errors with the server to be displayed in the Web UI

Technical details

$ node -v
v16.13.0
$ npm -v
8.6.0
  • OS: WSL2
  • Browser: Google Chrome
  • Biovalidator fetched and installed from dev branch as of today.

To reproduce

  • Open a terminal and deploy a local server.
node src/biovalidator
  • Access http://localhost:3020/ and make a validation request with valid schema/data combination (see example below).

Image

  • Stop Biovalidator server without closing the browser tab to localhost
$ node src/biovalidator
2025-02-26T16:02:06.372Z [info] Custom keywords successfully added. Number of custom keywords: 5
2025-02-26T16:02:06.415Z [info] ---------------------------------------------
2025-02-26T16:02:06.416Z [info] ------------ ELIXIR biovalidator ------------
2025-02-26T16:02:06.416Z [info] ---------------------------------------------
2025-02-26T16:02:06.417Z [info] Started server on port 3020 with base URL /
2025-02-26T16:02:06.417Z [info] Server available at http://localhost:3020/
2025-02-26T16:02:06.417Z [info] PID file is available at biovalidator/server.pid
2025-02-26T16:02:06.418Z [info] Writing logs to: biovalidator/logs/
2025-02-26T16:02:09.160Z [warn] Compiling schema with empty schema $id. Schema will not be cached.
2025-02-26T16:02:09.164Z [info] New validation request: Processed successfully in 4ms.
^C
  • Attempt, through the Web UI, to validate the same data and schema combination. Observe that the result is INVALID rather than ERROR ... Unreachable server or similar.

Image

Observed behaviour

Server connection errors are not handled correctly by the Web UI. The logic seems to be "when no positive validation outcome is given, then the validation is invalid", even if the error is not at data/schema level, but on the server level.

Expected behaviour

There should be a banner or error type that specifies that the server couldn't be reached.

Additional context

Reported by [email protected] during today's FEGA workshop.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions