test: assert list_services response uses proper protobuf structs (#78)

* test: assert list_services response uses proper protobuf structs

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

* test: move reflect/2 struct assertions into server_test.exs

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

* fix: downgrade reflection request logs to debug

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

---------

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Michael Heilmann <mjheilmann@users.noreply.github.com>

Author: yordis

test/integration/v1_reflection_test.exs

@@ -13,8 +13,13 @@ defmodule GrpcReflection.V1ReflectionTest do
 
   test "listing services", ctx do
     message = {:list_services, ""}
-    assert {:ok, %{service: service_list}} = run_request(message, ctx)
-    names = Enum.map(service_list, &Map.get(&1, :name))
+
+    assert {:ok, %Grpc.Reflection.V1.ListServiceResponse{service: service_list}} =
+             run_request(message, ctx)
+
+    assert Enum.all?(service_list, &match?(%Grpc.Reflection.V1.ServiceResponse{}, &1))
+
+    names = Enum.map(service_list, & &1.name)
 
     assert names == [
              "helloworld.Greeter",

test/integration/v1alpha_reflection_test.exs

@@ -13,8 +13,13 @@ defmodule GrpcReflection.V1alphaReflectionTest do
 
   test "listing services", ctx do
     message = {:list_services, ""}
-    assert {:ok, %{service: service_list}} = run_request(message, ctx)
-    names = Enum.map(service_list, &Map.get(&1, :name))
+
+    assert {:ok, %Grpc.Reflection.V1alpha.ListServiceResponse{service: service_list}} =
+             run_request(message, ctx)
+
+    assert Enum.all?(service_list, &match?(%Grpc.Reflection.V1alpha.ServiceResponse{}, &1))
+
+    names = Enum.map(service_list, & &1.name)
 
     assert names == [
              "helloworld.Greeter",

test/service/server_test.exs

@@ -27,6 +27,31 @@ defmodule GrpcReflection.ServerTest do
              Service.get_by_filename(filename)
   end
 
+  describe "reflect/2 list_services" do
+    setup do
+      Service.put_services([Helloworld.Greeter.Service])
+      :ok
+    end
+
+    test "returns a ListServiceResponse struct, not a plain map" do
+      assert {:ok, {:list_services_response, response}} =
+               GrpcReflection.Server.V1.reflect(Service, {:list_services, ""})
+
+      assert %Grpc.Reflection.V1.ListServiceResponse{} = response,
+             "expected a %Grpc.Reflection.V1.ListServiceResponse{} struct, got: #{inspect(response)}"
+    end
+
+    test "service entries are ServiceResponse structs, not plain maps" do
+      assert {:ok,
+              {:list_services_response,
+               %Grpc.Reflection.V1.ListServiceResponse{service: services}}} =
+               GrpcReflection.Server.V1.reflect(Service, {:list_services, ""})
+
+      assert [%Grpc.Reflection.V1.ServiceResponse{name: "helloworld.Greeter"}] = services,
+             "expected a list of %Grpc.Reflection.V1.ServiceResponse{} structs, got: #{inspect(services)}"
+    end
+  end
+
   describe "reflection state testing" do
     setup do
       Service.put_services([