Skip to content

Commit 10aa20f

Browse files
author
Shaw
committed
chore(ci): soften plugin-tests xprocess comment
The xprocess theory is plausible but unproven — plugin-shell's python tests use proc.kill() (SIGKILL only to immediate child, not pgroup) so a leaked sleep grandchild holding turbo's stdio pipes is equally likely. Reword the comment so future readers know what evidence we have.
1 parent 063a1b2 commit 10aa20f

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/test.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,11 @@ jobs:
107107
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
108108
TURBO_TEAM: ${{ vars.TURBO_TEAM }}
109109
TURBO_REMOTE_ONLY: true
110-
# Disable pytest-xprocess globally. Several plugins declare it as a dev
111-
# dep but never use it; its session-finalizer leaves orphan child
112-
# processes that hold turbo's stdio pipes open after the test passes,
113-
# so the job hangs until the 60m wall-clock timeout fires.
110+
# Several plugins declare pytest-xprocess as a dev dep but none use it.
111+
# Its pytest_terminal_summary hook was the last thing to print before
112+
# plugin-tests hung for 33 minutes in run 25234887145, so disable it
113+
# globally as a precaution. Safe: `-p no:NAME` is a no-op when NAME
114+
# isn't installed.
114115
PYTEST_ADDOPTS: "-p no:xprocess"
115116
steps:
116117
- uses: actions/checkout@v6

0 commit comments

Comments
 (0)