fix(ci): route coding tools ls through capability router

Author: NubsCarson

plugins/plugin-coding-tools/src/actions/enter-worktree.test.ts

@@ -11,6 +11,7 @@ import {
   type IAgentRuntime,
   type Memory,
   type State,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 
@@ -147,6 +148,7 @@ function makeGitRouter(
         throw new Error("model unavailable");
       },
     },
+    plugin: new UnavailableCapabilityRouter("desktop").plugin,
   };
 }
 
@@ -239,14 +241,7 @@ describe("ENTER_WORKTREE", () => {
     expect(calls).toEqual([
       {
         root: env.repoDir,
-        args: [
-          "worktree",
-          "add",
-          "-b",
-          "routed-feature",
-          worktreePath,
-          "main",
-        ],
+        args: ["worktree", "add", "-b", "routed-feature", worktreePath, "main"],
       },
     ]);
     expect(env.session.getCwd(env.conversationId)).toBe(

plugins/plugin-coding-tools/src/actions/exit-worktree.test.ts

@@ -11,6 +11,7 @@ import {
   type IAgentRuntime,
   type Memory,
   type State,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 
@@ -148,6 +149,7 @@ function makeGitRouter(
         throw new Error("model unavailable");
       },
     },
+    plugin: new UnavailableCapabilityRouter("desktop").plugin,
   };
 }
 

plugins/plugin-coding-tools/src/actions/ls.test.ts

@@ -9,6 +9,7 @@ import {
   type IAgentRuntime,
   type Memory,
   type State,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 
@@ -68,6 +69,7 @@ function makeListRouter(
     model: {
       status: async () => unavailableCapability("model", "model.status"),
     },
+    plugin: new UnavailableCapabilityRouter("desktop").plugin,
   };
 }
 

plugins/plugin-coding-tools/src/actions/ls.ts

@@ -3,7 +3,9 @@ import * as path from "node:path";
 
 import {
   type ActionResult,
+  CapabilityError,
   logger as coreLogger,
+  getCapabilityRouter,
   type HandlerCallback,
   type IAgentRuntime,
   type Memory,
@@ -34,6 +36,57 @@ interface LsEntry {
   size?: number;
 }
 
+function normalizeEntryKind(kind: string): EntryType {
+  if (kind === "directory") return "dir";
+  if (kind === "symlink") return "symlink";
+  return "file";
+}
+
+async function listWithCapabilityRouter(params: {
+  runtime: IAgentRuntime;
+  dir: string;
+  ignore?: string[];
+}): Promise<
+  | {
+      ok: true;
+      entries: LsEntry[];
+      truncated: boolean;
+      totalAfterIgnore: number;
+    }
+  | { ok: false; reason: "unavailable" | "failed"; message: string }
+> {
+  const router = getCapabilityRouter(params.runtime);
+  if (!router) return { ok: false, reason: "unavailable", message: "" };
+  try {
+    const result = await router.fs.list({
+      path: params.dir,
+      limit: ENTRY_LIMIT,
+      includeHidden: true,
+      ...(params.ignore ? { ignore: params.ignore } : {}),
+    });
+    return {
+      ok: true,
+      entries: result.entries.map((entry) => {
+        const type = normalizeEntryKind(entry.kind);
+        return type === "file"
+          ? { name: entry.name, type, size: entry.size }
+          : { name: entry.name, type };
+      }),
+      truncated: result.truncated,
+      totalAfterIgnore: result.totalAfterIgnore,
+    };
+  } catch (error) {
+    if (
+      error instanceof CapabilityError &&
+      error.code === "CAPABILITY_UNAVAILABLE"
+    ) {
+      return { ok: false, reason: "unavailable", message: error.message };
+    }
+    const message = error instanceof Error ? error.message : String(error);
+    return { ok: false, reason: "failed", message };
+  }
+}
+
 function globToRegExp(pattern: string): RegExp {
   let regex = "";
   let i = 0;
@@ -114,11 +167,43 @@ export async function lsHandler(
   const dir = validation.resolved;
 
   const ignoreRaw = readArrayParam(options, "ignore");
-  const ignoreMatchers: RegExp[] = (ignoreRaw ?? [])
-    .filter(
-      (entry): entry is string => typeof entry === "string" && entry.length > 0,
-    )
-    .map((entry) => globToRegExp(entry));
+  const ignore = (ignoreRaw ?? []).filter(
+    (entry): entry is string => typeof entry === "string" && entry.length > 0,
+  );
+
+  const routed = await listWithCapabilityRouter({
+    runtime,
+    dir,
+    ignore: ignore.length > 0 ? ignore : undefined,
+  });
+  if (routed.ok) {
+    const lines = [
+      `Directory: ${dir}`,
+      ...routed.entries.map((e) => (e.type === "dir" ? `${e.name}/` : e.name)),
+    ];
+    if (routed.truncated) {
+      lines.push(
+        `…[truncated, listed ${ENTRY_LIMIT} of ${routed.totalAfterIgnore} entries]`,
+      );
+    }
+    const text = lines.join("\n");
+    coreLogger.debug(
+      `${CODING_TOOLS_LOG_PREFIX} LS dir=${dir} count=${routed.entries.length} truncated=${routed.truncated}`,
+    );
+    if (callback) await callback({ text, source: "coding-tools" });
+    return successActionResult(text, {
+      entries: routed.entries,
+      truncated: routed.truncated,
+    });
+  }
+  if (routed.reason === "failed") {
+    return failureToActionResult({
+      reason: "io_error",
+      message: `readdir failed: ${routed.message}`,
+    });
+  }
+
+  const ignoreMatchers: RegExp[] = ignore.map((entry) => globToRegExp(entry));
 
   let names: string[];
   try {

plugins/plugin-coding-tools/src/actions/read.test.ts

@@ -5,6 +5,7 @@ import {
   CapabilityError,
   type ElizaCapabilityRouter,
   type IAgentRuntime,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { setupEnv, type TestEnv } from "./_test-helpers.js";
@@ -175,6 +176,7 @@ describe("READ", () => {
           });
         },
       },
+      plugin: new UnavailableCapabilityRouter("desktop").plugin,
     };
     const runtime = {
       ...env.runtime,

plugins/plugin-coding-tools/src/actions/write.test.ts

@@ -6,6 +6,7 @@ import {
   type ElizaCapabilityRouter,
   type FileWriteTextParams,
   type IAgentRuntime,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
 import { setupEnv, type TestEnv } from "./_test-helpers.js";
@@ -49,12 +50,12 @@ function makeWriteRouter(
     git: {
       status: async () => unavailableCapability("git", "git.status"),
       diff: async () => unavailableCapability("git", "git.diff"),
-      commandRun: async () =>
-        unavailableCapability("git", "git.command.run"),
+      commandRun: async () => unavailableCapability("git", "git.command.run"),
     },
     model: {
       status: async () => unavailableCapability("model", "model.status"),
     },
+    plugin: new UnavailableCapabilityRouter("desktop").plugin,
   };
 }
 

plugins/plugin-coding-tools/src/lib/run-shell.test.ts

@@ -2,6 +2,7 @@ import {
   CAPABILITY_ROUTER_SERVICE_TYPE,
   type ElizaCapabilityRouter,
   type IAgentRuntime,
+  UnavailableCapabilityRouter,
 } from "@elizaos/core";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { runShell } from "./run-shell.js";
@@ -65,6 +66,7 @@ function remoteRouter(): {
     model: {
       status: vi.fn(),
     },
+    plugin: new UnavailableCapabilityRouter("server").plugin,
   } satisfies ElizaCapabilityRouter;
   return { router, runCommand };
 }
@@ -103,14 +105,11 @@ describe("plugin-coding-tools runShell mobile routing", () => {
     process.env.ELIZA_RUNTIME_MODE = "local-yolo";
 
     await expect(
-      runShell(
-        { getService: () => null } as IAgentRuntime,
-        {
-          command: "codex exec 'touch changed.txt'",
-          cwd: "/workspace",
-          timeoutMs: 10_000,
-        },
-      ),
+      runShell({ getService: () => null } as IAgentRuntime, {
+        command: "codex exec 'touch changed.txt'",
+        cwd: "/workspace",
+        timeoutMs: 10_000,
+      }),
     ).rejects.toThrow(
       "Local coding tools are unavailable on iOS because the runtime does not expose shell, coding, or orchestrator subprocess capabilities.",
     );