Skip to content

Commit 284cbd9

Browse files
Shawclaude
andcommitted
fix(ci,cloud-frontend): silence biome lint warnings on intentional mount-only useEffect deps
direct-crypto-credit-card.tsx — `useEffect(() => setTokenSymbol(null), [selected?.network])` is intentionally keyed only on the network so we reset the token selection when (and only when) the network switches; biome was flagging it as missing deps. Added biome-ignore with rationale. Also picks up the parallel-agent landing/hero-section + ConditionalWalletProviders work that was uncommitted in the worktree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7768619 commit 284cbd9

3 files changed

Lines changed: 29 additions & 4 deletions

File tree

packages/cloud-frontend/src/components/landing/hero-section.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default function HeroSection() {
3939
<button
4040
type="button"
4141
onClick={launchEliza}
42-
className="inline-flex min-h-14 items-center justify-center gap-2 rounded-[3px] border border-black bg-black px-8 py-4 text-base font-medium text-white transition-colors hover:bg-white hover:text-black sm:text-lg"
42+
className="inline-flex min-h-14 items-center justify-center gap-2 rounded-[3px] bg-black px-8 py-4 text-base font-medium text-white transition-colors hover:bg-white hover:text-black sm:text-lg"
4343
>
4444
{t("cloud.landing.launchEliza", { defaultValue: "Launch Eliza" })}
4545
<ArrowRight className="h-5 w-5" />

packages/cloud-frontend/src/dashboard/billing/_components/direct-crypto-credit-card.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ export function DirectCryptoCreditCard({
184184
// When the network changes (or the underlying token list does), reset the
185185
// selected token to the network's default so we don't carry a stale BSC
186186
// selection into Base/Solana.
187+
// biome-ignore lint/correctness/useExhaustiveDependencies: selected?.network is the intentional reset signal here
187188
useEffect(() => {
188189
setTokenSymbol(null);
189190
}, [selected?.network]);

packages/cloud-frontend/src/providers/ConditionalWalletProviders.tsx

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,32 @@ export function ConditionalWalletProviders({
5656
}
5757

5858
return (
59-
<Suspense fallback={<div aria-busy="true" className="min-h-screen" />}>
60-
<LazyStewardWalletProviders>{children}</LazyStewardWalletProviders>
61-
</Suspense>
59+
<ChunkLoadErrorBoundary
60+
fallback={
61+
<div className="flex min-h-screen items-center justify-center p-6 text-center text-sm text-muted-foreground">
62+
<div>
63+
<p>Failed to load the wallet module.</p>
64+
<p className="mt-2">
65+
<button
66+
className="underline"
67+
onClick={() => {
68+
if (typeof window !== "undefined") {
69+
window.sessionStorage.removeItem(CHUNK_RELOAD_FLAG);
70+
window.location.reload();
71+
}
72+
}}
73+
type="button"
74+
>
75+
Reload page
76+
</button>
77+
</p>
78+
</div>
79+
</div>
80+
}
81+
>
82+
<Suspense fallback={<div aria-busy="true" className="min-h-screen" />}>
83+
<LazyStewardWalletProviders>{children}</LazyStewardWalletProviders>
84+
</Suspense>
85+
</ChunkLoadErrorBoundary>
6286
);
6387
}

0 commit comments

Comments
 (0)