chore: WS-1 fix remaining biome error-level findings in safe files

lalalune · claude · lalalune · commit 36597e1edb86 · 2026-05-12T02:25:36.000-07:00
useLiteralKeys/useOptionalChain/useNodejsImportProtocol/noUnusedImports/
noUnusedVariables/noUnusedFunctionParameters across build-mobile-bundle.mjs,
generate-registry.js, the registry vite config, device-bridge-client.ts,
final-checks, the core live-test harnesses, a couple test files.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/agent/scripts/build-mobile-bundle.mjs b/packages/agent/scripts/build-mobile-bundle.mjs
@@ -316,7 +316,7 @@ if (TARGET === "ios" || TARGET === "ios-jsc") {
     stubsDir,
     "ios-child-process.cjs",
   );
-  nativeStubs["child_process"] = path.join(stubsDir, "ios-child-process.cjs");
+  nativeStubs.child_process = path.join(stubsDir, "ios-child-process.cjs");
   nativeStubs["node:os"] = path.join(stubsDir, "ios-os.cjs");
   // Note: `bun:ffi` is provided natively by the iOS Bun runtime; the
   // ios-ffi.cjs stub only loads in dev/desktop fallbacks where this bundle
@@ -333,17 +333,17 @@ if (TARGET === "ios-jsc") {
   const throwStub = path.join(stubsDir, "ios-jsc-throw.cjs");
   const dnsStub = path.join(stubsDir, "ios-jsc-dns.cjs");
   nativeStubs["node:net"] = throwStub;
-  nativeStubs["net"] = throwStub;
+  nativeStubs.net = throwStub;
   nativeStubs["node:tls"] = throwStub;
-  nativeStubs["tls"] = throwStub;
+  nativeStubs.tls = throwStub;
   nativeStubs["node:dgram"] = throwStub;
-  nativeStubs["dgram"] = throwStub;
+  nativeStubs.dgram = throwStub;
   nativeStubs["node:cluster"] = throwStub;
-  nativeStubs["cluster"] = throwStub;
+  nativeStubs.cluster = throwStub;
   nativeStubs["node:worker_threads"] = throwStub;
-  nativeStubs["worker_threads"] = throwStub;
+  nativeStubs.worker_threads = throwStub;
   nativeStubs["node:dns"] = dnsStub;
-  nativeStubs["dns"] = dnsStub;
+  nativeStubs.dns = dnsStub;
   nativeStubs["node:dns/promises"] = dnsStub;
   nativeStubs["dns/promises"] = dnsStub;
   nativeStubs["bun:ffi"] = path.join(stubsDir, "ios-ffi.cjs");
diff --git a/packages/app-core/src/benchmark/lifeops-fake-backend.ts b/packages/app-core/src/benchmark/lifeops-fake-backend.ts
@@ -1330,10 +1330,9 @@ export class LifeOpsFakeBackend {
       ? `Re: ${parent.subject}`
       : pickString(kw, ["subject"], "Re:");
     const fromEmail = pickString(kw, ["from_email"], "me@example.test");
-    const toEmails =
-      parent && parent.from_email
-        ? [parent.from_email]
-        : pickStringArray(kw, ["to_emails"]);
+    const toEmails = parent?.from_email
+      ? [parent.from_email]
+      : pickStringArray(kw, ["to_emails"]);
     if (toEmails.length === 0) {
       throw new Error(
         `MESSAGE/draft_reply needs a parent email or to_emails (parent=${parentId})`,
diff --git a/packages/app/test/ui-smoke/ai-qa-capture.spec.ts b/packages/app/test/ui-smoke/ai-qa-capture.spec.ts
@@ -7,7 +7,6 @@ import {
   type AiQaRoute,
   type ReadyCheck,
   SETTINGS_SECTIONS,
-  THEMES,
   type Theme,
   VIEWPORT_SIZES,
   type ViewportName,
diff --git a/packages/core/src/features/advanced-capabilities/providers/facts.test.ts b/packages/core/src/features/advanced-capabilities/providers/facts.test.ts
@@ -119,7 +119,7 @@ describe("factsProvider keyword retrieval", () => {
 		// vi.setSystemTime, so pin Date.now() directly. This is the only
 		// timestamp facts.ts reads when ranking current facts.
 		const fixedNow = Date.parse("2026-05-11T12:00:00.000Z");
-		const nowSpy = vi.spyOn(Date, "now").mockReturnValue(fixedNow);
+		const _nowSpy = vi.spyOn(Date, "now").mockReturnValue(fixedNow);
 		const runtime = makeRuntime({
 			facts: [
 				memory(
diff --git a/packages/core/test/live/orchestrator-live-failover.ts b/packages/core/test/live/orchestrator-live-failover.ts
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
-import type { AgentRuntime, IAgentRuntime } from "@elizaos/core";
+import type { AgentRuntime } from "@elizaos/core";
 import type { SwarmCoordinator } from "@elizaos/plugin-agent-orchestrator";
 import { PTYService } from "@elizaos/plugin-agent-orchestrator";
 import { elizaOSCloudPlugin } from "@elizaos/plugin-elizacloud";
diff --git a/packages/core/test/live/orchestrator-task-thread-integration.ts b/packages/core/test/live/orchestrator-task-thread-integration.ts
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
-import type { AgentRuntime, IAgentRuntime } from "@elizaos/core";
+import type { AgentRuntime } from "@elizaos/core";
 import type { SwarmCoordinator } from "@elizaos/plugin-agent-orchestrator";
 import { PTYService } from "@elizaos/plugin-agent-orchestrator";
 import { createTestRuntime } from "../helpers/pglite-runtime.ts";
diff --git a/packages/core/test/live/orchestrator-task-thread-restart.ts b/packages/core/test/live/orchestrator-task-thread-restart.ts
@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
-import type { AgentRuntime, IAgentRuntime } from "@elizaos/core";
+import type { AgentRuntime } from "@elizaos/core";
 import type { SwarmCoordinator } from "@elizaos/plugin-agent-orchestrator";
 import { PTYService } from "@elizaos/plugin-agent-orchestrator";
 import { createTestRuntime } from "../helpers/pglite-runtime.ts";
diff --git a/packages/core/test/live/research-task-thread-live.ts b/packages/core/test/live/research-task-thread-live.ts
@@ -3,7 +3,7 @@ import { spawn } from "node:child_process";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
-import type { AgentRuntime, IAgentRuntime } from "@elizaos/core";
+import type { AgentRuntime } from "@elizaos/core";
 import { SwarmCoordinator } from "@elizaos/plugin-agent-orchestrator";
 import { createTestRuntime } from "../helpers/pglite-runtime.ts";
 
diff --git a/packages/core/test/live/task-agent-live-smoke.ts b/packages/core/test/live/task-agent-live-smoke.ts
@@ -3,7 +3,7 @@ import fs from "node:fs";
 import { createServer, type Server } from "node:http";
 import net from "node:net";
 import path from "node:path";
-import type { AgentRuntime, IAgentRuntime } from "@elizaos/core";
+import type { AgentRuntime } from "@elizaos/core";
 import {
 	cleanForChat,
 	listAgentsAction,
diff --git a/packages/native-plugins/llama/src/device-bridge-client.ts b/packages/native-plugins/llama/src/device-bridge-client.ts
@@ -378,7 +378,7 @@ export class DeviceBridgeClient {
         : hardware.cpuCores
       : hardware.cpuCores;
     const gpu = useNativeOverride
-      ? native?.gpu && native.gpu.available
+      ? native?.gpu?.available
         ? ({
             backend:
               native.gpu.backend === "metal" ||
diff --git a/packages/registry/scripts/generate-registry.js b/packages/registry/scripts/generate-registry.js
@@ -175,8 +175,8 @@ function normalizeGithubRepo(value) {
   return `${owner}/${repo}`;
 }
 
-function repositoryFromPackage(pkg) {
-  if (!pkg || !pkg.repository) {
+function _repositoryFromPackage(pkg) {
+  if (!pkg?.repository) {
     return null;
   }
   if (typeof pkg.repository === "string") {
@@ -680,7 +680,7 @@ function buildOutputs() {
   return { generated, index, summary };
 }
 
-function fileContents(filePath, data) {
+function fileContents(_filePath, data) {
   return `${JSON.stringify(data, null, 2)}\n`;
 }
 
diff --git a/packages/registry/site/vite.config.ts b/packages/registry/site/vite.config.ts
@@ -1,5 +1,5 @@
+import path from "node:path";
 import react from "@vitejs/plugin-react";
-import path from "path";
 import { defineConfig } from "vite";
 
 // https://vitejs.dev/config/
diff --git a/packages/scenario-runner/src/final-checks/index.ts b/packages/scenario-runner/src/final-checks/index.ts
@@ -345,7 +345,7 @@ function actionBlob(action: ScenarioContext["actionsCalled"][number]): string {
   return parts.join(" ").toLowerCase();
 }
 
-function actionMatchesChannel(
+function _actionMatchesChannel(
   action: ScenarioContext["actionsCalled"][number],
   channel: string,
 ): boolean {
