Commit 36dd40e
committed
fix(plugin-slack): drop unnecessary as-unknown cast on user WebClient — Greptile P2
`WebClient` in this file is aliased to `App["client"]` (line 26),
which is the same `@slack/web-api` `WebClient` class imported here
as `SlackWebClient`. The two types are structurally identical, so
the double `as unknown as WebClient` was masking — not bridging —
type compatibility. Drop the `unknown` indirection so any future
divergence between the Bolt-wrapped client and the direct import
surfaces as a type error at the cast site instead of being silently
swallowed.
Inline comment expanded to record the invariant for future readers.
Verification:
- bunx tsc --noEmit -p plugins/plugin-slack/tsconfig.json: clean
- bunx vitest run plugins/plugin-slack/src/: 17/17 pass
Follow-up to Greptile P2 on PR #7876 (post-merge).1 parent b19714e commit 36dd40e
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
732 | 732 | | |
733 | 733 | | |
734 | 734 | | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
735 | 739 | | |
736 | | - | |
| 740 | + | |
737 | 741 | | |
738 | 742 | | |
739 | 743 | | |
| |||
0 commit comments