Commit 9717967
fix(cloud): build steward + declare @stwd/react dep + chat-sidebar bug
Three fixes for cloud-cf-deploy's Verify Frontend tsc check:
1. cloud/.github/actions/setup-test-env/action.yml +
.github/workflows/cloud-cf-deploy.yml: add a "Build Steward" step
after `bun install`. @stwd/react ships type declarations from dist/
(gitignored). Without dist/, tsc can't resolve "@stwd/react" types
even though the workspace symlink exists.
2. cloud/apps/frontend/package.json + cloud/packages/ui/package.json:
declare @stwd/react: workspace:* explicitly so bun creates the
per-package node_modules symlinks. Required because lib/ (which
imports @stwd/react in StewardProvider.tsx) has no package.json
and relied on parent-dir resolution falling through.
3. cloud/packages/ui/src/components/layout/chat-sidebar.tsx:
`!room.characterId === DEFAULT_AGENT_ID` was comparing boolean
to string (always false). Changed to `!room.characterId ||
room.characterId === DEFAULT_AGENT_ID` to match the comment's
intent ("Show rooms with no character assignment OR default Eliza ID").
Verified locally: bun run --cwd cloud/apps/frontend typecheck now passes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 2b0be49 commit 9717967
5 files changed
Lines changed: 17 additions & 1 deletion
File tree
- .github/workflows
- cloud
- .github/actions/setup-test-env
- apps/frontend
- packages/ui
- src/components/layout
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
81 | 84 | | |
82 | 85 | | |
83 | 86 | | |
| |||
130 | 133 | | |
131 | 134 | | |
132 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
133 | 139 | | |
134 | 140 | | |
135 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
51 | 59 | | |
52 | 60 | | |
53 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
| 207 | + | |
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
| |||
0 commit comments