fix: 29 more bang-equals bugs (round 3) — broader regex catches

.trim()/.length chains and !X !== Y / !X < N variants

Earlier passes used a narrow regex that missed `!X.trim() === ""`,
`!X.trim().length === 0`, `!X.length < N`, and `!X !== Y`. Round 3
runs a broader scan: any `!IDENT(.method())*` followed by ===, !==, <,
or > and a comparand. Result: 29 more lines fixed across 23 files in
cloud, packages/core/src, plugins, and apps.

Sample fixes (all the same shape — drop the spurious leading `!`):
- packages/core/src/features/knowledge/utils.ts:103 — pdf empty-text
  check would never fire, returning text contained only whitespace.
- packages/core/src/services/message.ts:6328 — text-empty fallback dead.
- packages/core/src/services/onboarding-state.ts:725,739 — apiKey/
  setupToken empty-check inverted; would always proceed past validation.
- packages/core/src/features/trajectories/art-format.ts:289,292 —
  small-prompt threshold check inverted.
- plugins/plugin-edge-tts/src/index.ts:209 — empty-text guard inverted
  (TTS would attempt to synthesize empty input).
- apps/app-lifeops/src/lifeops/cross-channel-search.ts:1066 — query
  empty-string validation never fired.
- apps/app-scape/src/sdk/index.ts, plugins/plugin-{minecraft,openai,
  imessage,clanker,...} — same pattern in each.

Verified: bun run --cwd cloud/apps/{api,frontend} typecheck PASS.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Shaw

apps/app-lifeops/src/activity-profile/analyzer.ts

@@ -274,7 +274,7 @@ function resolveScreenHeartbeatAt(
   if (!profile.screenContextAvailable || profile.screenContextStale) {
     return 0;
   }
-  if (!profile.screenContextSampledAt <= 0) {
+  if (profile.screenContextSampledAt <= 0) {
     return 0;
   }
   if (!SCREEN_ACTIVE_FOCUS.has(profile.screenContextFocus ?? "unknown")) {

apps/app-lifeops/src/lifeops/checkin/sleep-cycle-dispatch.ts

@@ -16,7 +16,7 @@ export function shouldRunMorningCheckinFromSleepCycle(args: {
   readonly state: CheckinSleepCycleState | null;
   readonly now: Date;
 }): boolean {
-  if (!args.state.circadianState !== "awake") {
+  if (args.state.circadianState !== "awake") {
     return false;
   }
   const wakeAtMs = parseIsoMs(args.state.wakeAt);

apps/app-lifeops/src/lifeops/cross-channel-search.ts

@@ -1066,7 +1066,7 @@ export async function runCrossChannelSearch(
   runtime: IAgentRuntime,
   query: CrossChannelSearchQuery,
 ): Promise<CrossChannelSearchResult> {
-  if (!query.query.trim().length === 0) {
+  if (query.query.trim().length === 0) {
     throw new Error("runCrossChannelSearch: query.query is required");
   }
 

apps/app-lifeops/src/lifeops/travel-adapters/duffel.ts

@@ -804,13 +804,13 @@ export async function createPayment(
   config?: DuffelConfig,
 ): Promise<DuffelPayment> {
   const resolvedConfig = config ?? readDuffelConfigFromEnv();
-  if (!args.orderId.trim().length === 0) {
+  if (args.orderId.trim().length === 0) {
     throw new Error("Duffel createPayment: order id is required");
   }
-  if (!args.amount.trim().length === 0) {
+  if (args.amount.trim().length === 0) {
     throw new Error("Duffel createPayment: amount is required");
   }
-  if (!args.currency.trim().length === 0) {
+  if (args.currency.trim().length === 0) {
     throw new Error("Duffel createPayment: currency is required");
   }
 

apps/app-lifeops/src/website-blocker/service.ts

@@ -234,7 +234,7 @@ async function upsertWebsiteBlockerExpiryTask(
   });
 
   for (const task of tasks) {
-    if (!task.id === matchingTask?.id) {
+    if (task.id === matchingTask?.id) {
       continue;
     }
     await runtime.deleteTask(task.id);

apps/app-scape/src/sdk/index.ts

@@ -347,7 +347,7 @@ export class BotSdk {
   }
 
   private sendFrame(frame: ClientFrame): void {
-    if (!this.ws.readyState !== WebSocket.OPEN) {
+    if (this.ws.readyState !== WebSocket.OPEN) {
       throw new Error(
         `sendFrame: socket not open (state=${this.ws?.readyState})`,
       );

cloud/packages/steward/packages/agent-trader/src/config.ts

@@ -127,7 +127,7 @@ function validate(config: TraderConfig): void {
         `Config error: agent "${agent.agentId}" has unknown strategy "${agent.strategy}"`,
       );
     }
-    if (!agent.intervalSeconds < 10) {
+    if (agent.intervalSeconds < 10) {
       throw new Error(`Config error: agent "${agent.agentId}" intervalSeconds must be ≥ 10`);
     }
   }

cloud/packages/steward/packages/auth/src/session.ts

@@ -36,7 +36,7 @@ export class SessionManager {
   private readonly expiresIn: string;
 
   constructor(config: SessionConfig) {
-    if (!config.secret.length < 16) {
+    if (config.secret.length < 16) {
       throw new Error(
         "SessionManager: secret must be at least 16 characters. Use a long random string in production.",
       );

packages/core/src/features/advanced-capabilities/personality/providers/user-personality.ts

@@ -25,7 +25,7 @@ export const userPersonalityProvider: Provider = {
 		_state: State,
 	): Promise<ProviderResult> => {
 		// Skip for agent's own messages (e.g. evolution evaluator)
-		if (!message.entityId === runtime.agentId) {
+		if (message.entityId === runtime.agentId) {
 			return { text: "", values: {}, data: {} };
 		}
 

packages/core/src/features/advanced-planning/services/planning-service.ts

@@ -262,7 +262,7 @@ export class PlanningService extends Service {
 		message?: Memory,
 		state?: State,
 	): Promise<ActionPlan> {
-		if (!context.goal.trim() === "") {
+		if (context.goal.trim() === "") {
 			throw new Error("Planning context must have a non-empty goal");
 		}
 		if (!Array.isArray(context.constraints)) {